Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Significance Threshold #10

Open
Zentrik opened this issue Mar 13, 2024 · 2 comments
Open

Improve Significance Threshold #10

Zentrik opened this issue Mar 13, 2024 · 2 comments
Labels
low priority

Comments

@Zentrik
Copy link
Owner

Zentrik commented Mar 13, 2024

image
This shouldn't be so high, clearly an outlier.
Also the last 30 commits is probably too many given how infrequently we benchmark.
@Zentrik
Copy link
Owner Author

Zentrik commented Mar 13, 2024

Actually, maybe this example is fine. This was a genuine regression and fix, but many benchmarks are like this completely spuriously.
Hard to differentiate them, many of the latter are ~ns so we could have special logic for them.

@Zentrik
Copy link
Owner Author

Zentrik commented Mar 18, 2024

We do have a little special logic for ~ns now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
low priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Zentrik