Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

commands: Do not fetch containers for all commands #22

Open
einarf opened this issue Dec 16, 2019 · 0 comments
Open

commands: Do not fetch containers for all commands #22

einarf opened this issue Dec 16, 2019 · 0 comments

Comments

@einarf
Copy link
Member

einarf commented Dec 16, 2019

During setup we might for example want to test alerts as a start. We'll be met by a wall of stack traces if the docker service cannot be reached. This does not make sense to do for alert command.

In addition we check docker availability twice during the status command. Once when entering the cli and once again in the status function.

Having a BaseCommand providing a method to get containers is probably better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant