From 5fcdeceef1ceb19900b821b6faec5bc44beaa492 Mon Sep 17 00:00:00 2001
From: zhgchgli0718 <zhgchgli@gmail.com>
Date: Tue, 4 Oct 2022 11:25:09 +0800
Subject: [PATCH] [fix] optimize welcome message send timing

---
 .version              |  2 +-
 lib/AndroidFetcher.rb | 10 +++++-----
 lib/AppleFetcher.rb   | 11 +++++------
 3 files changed, 11 insertions(+), 12 deletions(-)

diff --git a/.version b/.version
index 785cda8..8c9698a 100644
--- a/.version
+++ b/.version
@@ -1 +1 @@
-1.3.3
\ No newline at end of file
+1.3.4
\ No newline at end of file
diff --git a/lib/AndroidFetcher.rb b/lib/AndroidFetcher.rb
index 2a241f0..ee8b741 100644
--- a/lib/AndroidFetcher.rb
+++ b/lib/AndroidFetcher.rb
@@ -132,13 +132,13 @@ def execute()
 
             puts "[AndroidFetcher] latest review: #{reviews.last.body}, #{reviews.last.createdDateTimestamp}"
             setPlatformLatestCheckTimestamp(reviews.last.createdDateTimestamp)
+        end
 
-            # init first time, send welcome message
-            if latestCheckTimestamp == 0 
-                sendWelcomMessage()
-                return
-            end
 
+        # init first time, send welcome message
+        if latestCheckTimestamp == 0 
+            sendWelcomMessage()
+        elsif reviews.length > 0
             processReviews(reviews, platform)
         end
     end
diff --git a/lib/AppleFetcher.rb b/lib/AppleFetcher.rb
index f7fbedf..9dae6f4 100644
--- a/lib/AppleFetcher.rb
+++ b/lib/AppleFetcher.rb
@@ -35,13 +35,12 @@ def execute()
 
             puts "[AppleFetcher] latest review: #{reviews.last.body}, #{reviews.last.createdDateTimestamp}"
             setPlatformLatestCheckTimestamp(reviews.last.createdDateTimestamp)
+        end
 
-            # init first time, send welcome message
-            if latestCheckTimestamp == 0 
-                sendWelcomMessage()
-                return;
-            end
-
+        # init first time, send welcome message
+        if latestCheckTimestamp == 0 
+            sendWelcomMessage()
+        elsif reviews.length > 0
             reviews = fullfillAppInfo(reviews)
             processReviews(reviews, platform)
         end