Update ko.debug check to support ko 3.4.0+ in debug mode

Should fix #41
ZiadJ · Dec 13, 2016 · afe14ee · afe14ee
1 parent 87fa4c6
commit afe14ee
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 4 deletions.
diff --git a/dist/ko-reactor.js b/dist/ko-reactor.js
@@ -198,8 +198,10 @@ ko['watch'] = function (target, options, evaluatorCallback, context) {
 
     // Subscriptions are stored under either the _subscriptions field for the debug version
     // or the F, H or M fields when minified depending on the version used.
+    // NOTE: we used to use ko.DEBUG to detect the debug versionbut it was removed in 3.4.0+,
+    //       so we now check the existence of a "subscription" function.
     var subscriptionsField;
-    switch (ko.DEBUG || ko.version) {
+    switch (typeof ko.subscription == 'function' || ko.version) {
         case true: subscriptionsField = '_subscriptions'; break;
         case "3.0.0": subscriptionsField = 'F'; break;
         case "3.1.0": subscriptionsField = 'H'; break;

diff --git a/dist/ko-reactor.min.js b/dist/ko-reactor.min.js
diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
   "name": "ko-reactor",
   "author": "Ziad Jeeroburkhan",
-  "version": "1.3.8",
+  "version": "1.3.9",
   "repository": {
     "type": "git",
     "url": "https://github.com/ZiadJ/knockoutjs-reactor.git"

diff --git a/src/knockout.reactor.js b/src/knockout.reactor.js
@@ -198,8 +198,10 @@ ko['watch'] = function (target, options, evaluatorCallback, context) {
 
     // Subscriptions are stored under either the _subscriptions field for the debug version
     // or the F, H or M fields when minified depending on the version used.
+    // NOTE: we used to use ko.DEBUG to detect the debug versionbut it was removed in 3.4.0+,
+    //       so we now check the existence of a "subscription" function.
     var subscriptionsField;
-    switch (ko.DEBUG || ko.version) {
+    switch (typeof ko.subscription == 'function' || ko.version) {
         case true: subscriptionsField = '_subscriptions'; break;
         case "3.0.0": subscriptionsField = 'F'; break;
         case "3.1.0": subscriptionsField = 'H'; break;