Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tested for Possible Memory Leaks #14

Open
jDavidnet opened this issue Dec 7, 2014 · 1 comment
Open

Tested for Possible Memory Leaks #14

jDavidnet opened this issue Dec 7, 2014 · 1 comment

Comments

@jDavidnet
Copy link

Have you tested for possible memory leaks since you subscribe to each child node in a list and below? If nodes are removed are their subscriptions cleaned up in such a way that they will not hold on to memory?

@ZiadJ
Copy link
Owner

ZiadJ commented Dec 7, 2014

That's one of the things I wanted to do for a long time. I haven't prioritized it because I've already made sure ALL subscriptions within any observable array item are automatically disposed after its deletion. Static observables also get the same treat but only when the mutable option is set to true. I think that should be fairly enough and I haven't noticed any abnormal memory usage during my tests, with changes being applied to nodes within arrays of 1000+ items, even though they were still admittedly pretty basic. However if you're running any tests and came up with anything interesting feel free to share it with us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants