Fix CI issues: Python 3.8 compatibility and linting errors

- Fix Python 3.8 compatibility by using List instead of list[] syntax
- Remove unused imports across all modules and tests
- Fix f-string issues without placeholders
- Auto-fix all ruff linting errors
- Tests now pass on all Python versions

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>

Author: ritwik-g

helm_values_manager/commands/generate.py

@@ -1,13 +1,12 @@
 """Generate command implementation."""
-import sys
 from typing import Optional
 
 import typer
 from rich.console import Console
 
 from helm_values_manager.errors import ErrorHandler, GeneratorError
 from helm_values_manager.generator import generate_values
-from helm_values_manager.utils import get_values_file_path, load_schema, load_values
+from helm_values_manager.utils import load_schema, load_values
 from helm_values_manager.validator import validate_single_environment
 
 console = Console()
@@ -26,9 +25,6 @@ def generate_command(
     if not schema_obj:
         ErrorHandler.print_error("generate", "Schema file not found")
 
-    # Determine values file path
-    values_path = values or get_values_file_path(env)
-    
     # Load values
     values_data = load_values(env, values)
 

helm_values_manager/commands/schema.py

@@ -1,5 +1,5 @@
 import json
-from typing import Any, Optional
+from typing import Any
 
 import typer
 from rich.console import Console
@@ -309,7 +309,7 @@ def remove_command(
 
     # Confirm removal
     if not force:
-        console.print(f"\n[bold]Value to remove:[/bold]")
+        console.print("\n[bold]Value to remove:[/bold]")
         console.print(f"Key: {value.key}")
         console.print(f"Path: {value.path}")
         console.print(f"Description: {value.description}")

helm_values_manager/commands/validate.py

@@ -8,7 +8,7 @@
 
 from helm_values_manager.errors import ErrorHandler
 from helm_values_manager.models import Schema
-from helm_values_manager.utils import load_schema, load_values, get_values_file_path
+from helm_values_manager.utils import load_values
 from helm_values_manager.validator import validate_single_environment
 
 console = Console()

helm_values_manager/commands/values.py

@@ -1,17 +1,16 @@
 import json
 import os
-from typing import Any, Optional
+from typing import Optional
 
 import typer
 from rich.console import Console
 from rich.prompt import Confirm, Prompt
 from rich.table import Table
 
 from helm_values_manager.commands.schema import parse_value_by_type
-from helm_values_manager.models import SchemaValue, SecretReference
-from helm_values_manager.errors import ErrorHandler, ValuesError, SchemaError
+from helm_values_manager.models import SchemaValue
+from helm_values_manager.errors import ErrorHandler, SchemaError
 from helm_values_manager.utils import (
-    get_values_file_path,
     is_secret_reference,
     load_schema,
     load_values,
@@ -325,7 +324,7 @@ def init_command(
         # Handle skip-defaults flag
         if skip_defaults and has_default:
             skipped_count += 1
-            console.print(f"  → Skipping field with default value")
+            console.print("  → Skipping field with default value")
             continue
 
         # Handle force mode
@@ -338,11 +337,11 @@ def init_command(
         elif force and not has_default and not schema_value.required:
             # Skip optional fields without defaults in force mode
             skipped_count += 1
-            console.print(f"  → Skipping optional field without default")
+            console.print("  → Skipping optional field without default")
             continue
         elif force and not has_default and schema_value.required:
             # Required fields without defaults must be prompted even in force mode
-            console.print(f"  → Required field with no default, prompting...")
+            console.print("  → Required field with no default, prompting...")
             # Skip the "Set value?" prompt and go directly to value input
             action = "y"  # Force yes for required fields in force mode
         else:
@@ -420,7 +419,7 @@ def init_command(
     save_values(values, env, values_path)
 
     # Show summary
-    console.print(f"\n[bold]Summary:[/bold]")
+    console.print("\n[bold]Summary:[/bold]")
     console.print(f"  Set {set_count} values")
     console.print(f"  Skipped {skipped_count} values")
 

helm_values_manager/errors.py

@@ -1,5 +1,4 @@
 """Centralized error handling utilities for consistent error formatting."""
-import sys
 from typing import List, Optional
 
 import typer

helm_values_manager/generator.py

@@ -1,11 +1,11 @@
 """Generator module for creating values.yaml from schema and values."""
 import os
-from typing import Any, Dict, Optional
+from typing import Any, Dict
 
 import yaml
 
 from helm_values_manager.errors import GeneratorError
-from helm_values_manager.models import Schema, SchemaValue, SecretReference
+from helm_values_manager.models import Schema
 from helm_values_manager.utils import is_secret_reference
 
 

helm_values_manager/models.py

@@ -1,4 +1,4 @@
-from typing import Any, Dict, Literal, Optional, Union
+from typing import Any, Dict, List, Literal, Optional, Union
 
 from pydantic import BaseModel, Field, RootModel
 
@@ -18,7 +18,7 @@ class SchemaValue(BaseModel):
 
 class Schema(BaseModel):
     version: str = Field(default="1.0", description="Schema version")
-    values: list[SchemaValue] = Field(default_factory=list, description="List of value definitions")
+    values: List[SchemaValue] = Field(default_factory=list, description="List of value definitions")
 
 
 class SecretReference(BaseModel):
@@ -27,7 +27,7 @@ class SecretReference(BaseModel):
 
 
 # Type for a value in the values file - can be a regular value or a secret reference
-ValueEntry = Union[str, int, float, bool, list, dict, SecretReference]
+ValueEntry = Union[str, int, float, bool, List, Dict, SecretReference]
 
 
 class ValuesFile(RootModel[Dict[str, Any]]):

helm_values_manager/utils.py

@@ -2,7 +2,7 @@
 from pathlib import Path
 from typing import Any, Dict, Optional
 
-from helm_values_manager.models import Schema, SecretReference, ValuesFile
+from helm_values_manager.models import Schema
 
 
 def load_schema(schema_path: str = "schema.json") -> Optional[Schema]:

tests/test_edge_cases.py

@@ -1,6 +1,5 @@
 """Tests for edge cases and error conditions."""
 import json
-import os
 from pathlib import Path
 
 import pytest

tests/test_generator.py

@@ -1,7 +1,5 @@
 """Tests for the generator module."""
 import json
-import os
-from pathlib import Path
 
 import pytest
 import yaml