Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check first, update only when needed #34

Closed
degudejung opened this issue Dec 24, 2024 · 6 comments
Closed

Check first, update only when needed #34

degudejung opened this issue Dec 24, 2024 · 6 comments

Comments

@degudejung
Copy link

Hallo Ihr beiden,
danke für dieses Script!

I like it for its simplicity and because it needs no root privileges to get the (non-cron) job done.

My problem with it is that I run out of my "DynDNS Update Limit / 24h" at ipv64 because it don't check if an update is necessary (IP change) or not (IP same).

So in case you consider updating this in the future, that feature would be highly appreciated.

Thanks

@Zoey2936
Copy link
Member

The limit is per request? I always thought is is per ip range

@degudejung
Copy link
Author

Don‘t know how it does the counting exactly, but my understanding is that every time you call the update.php it „costs“ you 1/1024 per day. So if you do a 5m cycle, you are limited to 3 prefixes/domains or you(r script) will run into overcommitting.

I tried forking and inserting the logic of alcapone1933 for pre-checking but since I never coded before, that was beyond what I could do on a night.

@Zoey2936
Copy link
Member

hello, this is now supported, but you need to add the DUD env as per compose.yaml, please report back if it works

@degudejung
Copy link
Author

Hi,
first of all great that you picked up on this so quickly. Thanks.

Here's how it looks to me:

  • your new dig checks do not affect the limit now
  • when the IP changes, it updates the A-record
  • since you only write to /tmp/IPv4.json after an update, the container appears "unhealthy" until the first update (which could be days/weeks)
  • don't know why you say "no prefixes/sub-domains" - I do just that and it works fine

It took me a while to see that it's really "DUDs" instead of "DUD" but that was just me.

@Zoey2936
Copy link
Member

sorry, I renamed DUD to DUDs (plural) to support multiple domain when using the account key
what do you mean with the dig check? it worked in my tests
but for the health check you are right, maybe there should be one update in any case, I will add it

@Zoey2936
Copy link
Member

with the prefixes, it works when using the record key, domain or account key will not work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants