Fix CI Failures #7
Merged
+68
−59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maybe under the same section added in jupyter-server#1417 ("Starting asynchronous tasks from an extension") |
|
@Zsailer Could you approve the workflow or review the code? 😊 |
Zsailer
approved these changes
Feb 13, 2025
|
Amazing work @Darshan808 and @krassowski. Thank you, folks, for jumping in here! |
|
The Actions here are outdated. Let's merge this and let the tests run in the upstream PR. If we need to iterate in another PR here, that's totally fine. |
Zsailer
merged commit c076f60
into
Zsailer:extension-async-start
32 of 61 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes CI failures in JupyterLab downstream tests and test_examples.
One thing I wasn't sure about—where should we document the message banner shown before async extensions are registered? And also I think we need to show some message after the async extensions are registered. Let me know your thoughts!