Logged out of app after auto update

[aaomidi]

The program silently logs out and does NOT notify the user.

[mkotb]

As I mentioned before, a fix for this would only mean you don't "login" but you still have to open a tab for the firebase service worker to register, otherwise firebase messaging won't work. I will do more testing to see what is possible with firebase after the user is logged in. if this is the case, though, maybe we can just send a notification to the user that to continue using zync they must login again.

…

On Aug 27, 2017 12:30 AM, "Amir Ali Omidi" ***@***.***> wrote: Assigned #13 <#13> to @mkotb <https://github.com/mkotb>. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#13 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGEb8nzQlUy1mpNNk-6g7GJ8Mjvwb4v-ks5scRsIgaJpZM4PDufq> .

[aaomidi]

I don't like the "solution" of making them login. We need to exhaustively search for alternative methods of doing this before we end up doing that.

[devmattrick]

As I mentioned before, a fix for this would only mean you don't "login" but
you still have to open a tab for the firebase service worker to register

@mkotb are you certain of that? From my understanding, once a service worker is registered, it is register permanently until removed manually. I'm not sure how that works with extensions, but that's the way it works in websites and how it is defined in the spec.

[aaomidi]

Service Worker termination by a timeout timer was canceled because DevTools is attached.

I saw this while looking at the logs. Are we killing the service workers manually?

[mkotb]

@aaomidi We aren't killing them manually. This is simply Chrome notifying you that since DevTools is open (you're inspecting it), it would've usually killed the service worker.

@devmattrick To clarify, I can register the service worker from the background script perfectly fine. But Chrome aggressively attempts to kill idle service workers and restart them (performance and battery purposes). As a result, their states are not persistent and writing them as such ends up creating a buggy service worker. You can find more info here.

The problem at hand here isn't that I can't register the service worker, however connecting to firebase messaging is a problem. I will do some testing and report back on my findings.

[mkotb]

Okay, after some testing and finicking with firebase, I have seemed to get it to work and register properly on my machine. I can't guarantee that it will work consistently and would recommend for other people to test the functionality for them. Pushing changes shortly