Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storing passwords #60

Open
otajor opened this issue Dec 2, 2016 · 0 comments
Open

Storing passwords #60

otajor opened this issue Dec 2, 2016 · 0 comments

Comments

@otajor
Copy link

otajor commented Dec 2, 2016

Just made this comment on another repo and I know you might not have covered this yet. However:

Looks like you're storing passwords in plain text and then just comparing the user input to what you have in the database when the user logs in.

This is pretty bad practice because if someone steals your database they will have all the user passwords. To prevent this you should hash and salt your passwords and never store the actual plain text password, ever.

Don't really expect you to fix this in a couple of hours code review, but maybe check out how this group did it here:
https://github.com/FAC9/the-badgerer/blob/master/src/handlers/loginHandler.js
and here:
https://github.com/FAC9/the-badgerer/blob/master/src/handlers/newUserHandler.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant