Skip to content

Update script to remove label 'status: waiting-for-author-response'.#2098

Open
polina-c wants to merge 4 commits into
mainfrom
remove-label
Open

Update script to remove label 'status: waiting-for-author-response'.#2098
polina-c wants to merge 4 commits into
mainfrom
remove-label

Conversation

@polina-c

@polina-c polina-c commented Jul 25, 2026

Copy link
Copy Markdown
Collaborator

Renames status: waiting-for-user-response to status: waiting-for-author-response, and teaches the triage automation to clear it once the author replies.

Behavior

  • Renames the label across scripts/triage.mjs, the a2ui-issue-triage skill (criteria, dashboard, suggest_triage.py) and docs/contributing/triage.md.
  • scripts/triage.mjs now removes the waiting label when the item's author has replied, and applies status: needs-triage in the same run rather than leaving it for the next one.
  • The waiting-label check moved to the top of flagReason, so a parked item is off the triage queue entirely — previously it only suppressed the issue rules, not the PR or unanswered-comment ones.
  • The run summary reports how many waiting labels were cleared.
  • docs/contributing/triage.md notes which of the two labels is automated and which is applied by hand.

Tests

  • Unit tests for authorHasResponded, including the opening-post regression above.
  • Reconciliation tests for the label being kept while awaiting the author, cleared once they reply, cleared-and-flagged in a single run, and backed off when a concurrent run already reconciled both labels.
  • Split the comment() test factory into comment() (raw API payload) and event() (the normalized event fetchContributions produces), so each test states which layer it exercises.
  • Fixes 6 pre-existing failures in scripts/triage.test.mjs. They went unnoticed because the suite never ran in CI — see below.

CI

  • web_ci.yml gains a ci-scripts job, gated on scripts/**, that runs node --test scripts/*.test.mjs. Nothing executed triage.test.mjs before, which is how the failures above survived on main.

TODO after merge: rename the label in GitHub.

gemini-code-assist[bot]

This comment was marked as outdated.

@polina-c

Copy link
Copy Markdown
Collaborator Author

/gemini review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request renames the 'waiting-for-user-response' label to 'waiting-for-author-response' across the codebase and updates the triage automation script to automatically clear this label once the author replies. The test suite has been expanded to cover this new logic. Feedback was provided to improve the robustness of the event helper in scripts/triage.test.mjs by supporting both camelCase and snake_case overrides.

Comment thread scripts/triage.test.mjs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant