Update script to remove label 'status: waiting-for-author-response'.#2098
Open
polina-c wants to merge 4 commits into
Open
Update script to remove label 'status: waiting-for-author-response'.#2098polina-c wants to merge 4 commits into
polina-c wants to merge 4 commits into
Conversation
Collaborator
Author
|
/gemini review |
Contributor
There was a problem hiding this comment.
Code Review
This pull request renames the 'waiting-for-user-response' label to 'waiting-for-author-response' across the codebase and updates the triage automation script to automatically clear this label once the author replies. The test suite has been expanded to cover this new logic. Feedback was provided to improve the robustness of the event helper in scripts/triage.test.mjs by supporting both camelCase and snake_case overrides.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renames
status: waiting-for-user-responsetostatus: waiting-for-author-response, and teaches the triage automation to clear it once the author replies.Behavior
scripts/triage.mjs, thea2ui-issue-triageskill (criteria, dashboard,suggest_triage.py) anddocs/contributing/triage.md.scripts/triage.mjsnow removes the waiting label when the item's author has replied, and appliesstatus: needs-triagein the same run rather than leaving it for the next one.flagReason, so a parked item is off the triage queue entirely — previously it only suppressed the issue rules, not the PR or unanswered-comment ones.docs/contributing/triage.mdnotes which of the two labels is automated and which is applied by hand.Tests
authorHasResponded, including the opening-post regression above.comment()test factory intocomment()(raw API payload) andevent()(the normalized eventfetchContributionsproduces), so each test states which layer it exercises.scripts/triage.test.mjs. They went unnoticed because the suite never ran in CI — see below.CI
web_ci.ymlgains aci-scriptsjob, gated onscripts/**, that runsnode --test scripts/*.test.mjs. Nothing executedtriage.test.mjsbefore, which is how the failures above survived onmain.TODO after merge: rename the label in GitHub.