fix: align v0.9 slider schema with spec - #1487
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes the step property from the SliderApi schema and the corresponding Angular SliderComponent. A regression test was added to verify that the schema now rejects the step property. Feedback suggests improving the robustness of this test by ensuring it specifically fails due to the unrecognized step key rather than other potential validation errors, and provided a code suggestion to implement this check.
|
Tightened the regression in 192683b so it first verifies the slider parses without |
|
Quick follow-up here. I tightened the regression after review; if this direction still makes sense, I can refresh it against main since it is showing non-mergeable now. |
|
Adding the |
2 similar comments
|
Adding the |
|
Adding the |
github-actions
Bot
added
the
status: needs-triage
|
@gspencergoog , can you please review it to get it out of discussion queue? |
github-actions
Bot
removed
the
status: needs-triage
gspencergoog
left a comment
gspencergoog
left a comment
There was a problem hiding this comment.
@kiwigitops Thanks for the PR! Good eye! Okay, let's make this change.
In v1.0 it will be called steps anyhow, and represent the number of divisions rather than absolute step count, so this prevents us from needing to break that functionality in v1.0.
3 participants
Closes #1384.
Summary
stepproperty from the v0.9 WebCoreSliderApischemaSlider.stepis rejected instead of diverging from the frozen JSON catalogVerification
npm test -- --watch=falsefromrenderers/web_corenpx ng build libfromrenderers/angular