Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log number of OK keypresses #144

Open
Coder-256 opened this issue Feb 3, 2020 · 5 comments
Open

Log number of OK keypresses #144

Coder-256 opened this issue Feb 3, 2020 · 5 comments
Labels
enhancement New feature or request

Comments

@Coder-256
Copy link

Is your feature request related to a problem? Please describe.
I wonder what percentage of presses are shaky for each key. For example, E is at the top of my list, but that's probably because I use it a lot

Describe the solution you'd like
I wish Unshaky logged the number of all keypresses, both the overall total and totals for each key. Maybe the Statistics window could look something like:

Key Dismissed % Dismissed Ignored Total
E 10% 20 180 200
N 6% 5 75 80
... ... ... ... ...

And the dropdown could say, "Dismissed 25 shaky presses... (8.93% of 280)"

Describe alternatives you've considered
The table format and message text could change.

Additional context
N/A

@aahung aahung added the enhancement New feature or request label Feb 3, 2020
@aahung
Copy link
Owner

aahung commented Feb 3, 2020

Thanks! Nice feature to implement!

@sburford
Copy link

sburford commented Apr 30, 2020

Exposed per key counts and statistics are potentially harmful; for example comparing key counts before and after a password entry (eg. asking someone to unlock their device twice). If #25 is not fixed this seems like less of an issue (only affecting non-password secrets).

@aahung
Copy link
Owner

aahung commented May 1, 2020

that's definitely something we should consider here. potential malware might rely on monitoring unshaky's log (which requires much lower permission than listening to key press itself) to log the keypress.

@toriningen
Copy link

Maybe make Shaky log available to root only, and require elevated privileges to look at per-key statistics.

@aahung aahung closed this as completed Sep 23, 2020
@aahung aahung reopened this Sep 23, 2020
@aahung
Copy link
Owner

aahung commented Dec 13, 2020

Maybe make Shaky log available to root only, and require elevated privileges to look at per-key statistics.

Unshaky does not require root permission to launch right now, I don't think it is worth to do this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants