Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

peer review: Need to fix module hierarchy diagram to communicate design decisions<Promish Kandel Team 22 TeleHealth Insights> #215

Open
PromishKandel opened this issue Jan 20, 2025 · 0 comments
Open

peer review: Need to fix module hierarchy diagram to communicate design decisions<Promish Kandel Team 22 TeleHealth Insights> #215

PromishKandel opened this issue Jan 20, 2025 · 0 comments
Labels
peer review To be used with different parties for review purposes

Comments

@PromishKandel
Copy link

PromishKandel commented Jan 20, 2025 •
edited
Loading

artifact under review.

Design Doc MIS.md

team number (for the team doing the review). Team 22

description of issue.

Reading through you MIS, I can see that there is some level of hierarchy that is trying to be communicated but I'm finding that this doesn't translate to your diagram. Make it a Hierarchical structure so that the flow is more natural because right now I am having to look all over the diagram to figure out what layers the modules are in. Its not easy to read the software architectural design you are trying to present, the design patterns and decisions are a bit unclear.

https://github.com/aarnphm/tinymorph/blob/main/docs/content/images/modulediagram.png
@PromishKandel PromishKandel added the peer review To be used with different parties for review purposes label Jan 20, 2025
@PromishKandel PromishKandel changed the title peer review: <Promish Kandel Team 22 TeleHealth Insights> peer review: Need to fix module hierarchy diagram to communicate design decisions<Promish Kandel Team 22 TeleHealth Insights> Jan 20, 2025
@mitcholll mitcholll mentioned this issue Jan 20, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
peer review To be used with different parties for review purposes
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@PromishKandel