Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing files for testing #16

Open
gititGoro opened this issue Jul 7, 2020 · 1 comment
Open

missing files for testing #16

gititGoro opened this issue Jul 7, 2020 · 1 comment

Comments

@gititGoro
Copy link

gititGoro commented Jul 7, 2020

Hi there,
When I tried to run the tests, I noticed a great deal of implied dependencies but no package.json.
I also came across lines like this:

import {getTruffleContractInstance} from '../../utils/truffle/truffle-core-utils';

but none of truffle's libraries in any of their repos have this exported function (as far as I can tell).

This line

import {NIL_ADDRESS, ETHEREUM_ADDRESS} from '../../utils/constants';

looks very Aave specific since the source code contains that dummy ethereum address.

I think there's a toplevel utils folder that hasn't been committed.

@katalonne
Copy link

@The-3D @ernesto-usal ???

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants