New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flawed Encryption/Security #2

Open

sreejithbnaick opened this issue Jun 11, 2019 · 1 comment

Labels

pending

sreejithbnaick commented Jun 11, 2019

Currently library is using following method to get password for decryption, which is always constant.

private fun getPassword(): String {
val uuid = (getSign() + getUUID())
return getSHA256(uuid) ?: uuid
}

Passwords should be generated randomly for each sesssion and stored securely, like Android Keystore system: https://developer.android.com/training/articles/keystore

abbasnaqdi added invalid and removed invalid labels

Owner

abbasnaqdi commented Jun 17, 2019

Hi, Thanks for submitting the issue.
I will investigate this as soon as possible.

abbasnaqdi added the pending label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment