You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 720f76b
Browse filesBrowse the repository at this point in the historyBrowse files
fix: a round on a round by its definition is the default; its flag is retired (tangency-labs#2647)
`UpstreamFixes::fillet_round_on_round_as_definition` is gone and its path is the
only one: a round of one radius on a face that is a round of one radius by its
definition is built as its definition and certified on it, and a definition
evaluated at one of its stations takes the side it is asked for. It still needs
`fillet_round_as_definition` and `fillet_gn_section_generator`, which build the inner
round as its definition.
The test of the old path (`without_wr714_the_round_on_the_round_is_built_as_before`)
is deleted with it; the SmoothInteriorPlan opt-in test now turns off
`fillet_round_as_definition`, the one opt-in left; tangency-labs#2364's rig kernels and the
corpus's fixes.json drop the name.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DtL5M41G8Nua7HvuFPZkmJ
Copy file name to clipboardExpand all lines: crates/solidcore/src/kernel.rs
-2Lines changed: 0 additions & 2 deletions
Original file line number
Diff line number
Diff line change
@@ -1541,8 +1541,6 @@ pub struct UpstreamFixes {
1541
1541
/// those of the circles beside it: that round is then 8.1e-5 off. Off: the fork's
1542
1542
/// 523bc25 and 5e8c9c1 (WR-711, a fix of WR-708).
1543
1543
pub fillet_exact_arc_spans:bool,
1544
-
/// With [`Self::fillet_round_as_definition`] (and [`Self::fillet_gn_section_generator`]) also on (a no-op otherwise): a round of one radius on a face that is itself a round of one radius between NURBS faces by its definition is built as its definition, two deep. Its certificate encloses the inner definition's partials over each of its boxes: each box cut at the inner round's leader knots it crosses, the inner round's feet by Krawczyk's operator on the faces under them (their box cut at the knot lines it crosses, each part on its own polynomial piece, hulled), then its arc in interval arithmetic, in the centred form where one order more is held and the feet cross no knot line ([`crate::blend::fillet_section::definition_box`]): the inner definition piecewise, each piece exact, whatever its net's stations (#2570). The outer round has a station wherever its rail crosses one of the inner round's stations (its net's knots), where the inner round is only C1, and takes one-sided series there: a definition evaluated at one of its stations takes its partials on the side it is asked for (`EvaluateDefinition`'s `bBefore`, from the evaluators' `FromLeft` flags), a foot on a knot line of its face on the piece it moves into. A law or G^n inner round, and a G^n or variable outer round, are refused or built as before. Off: a round on a definition is built as before, and a definition's partials at a station are the side after it (WR-714, #2298; the fork's tangency-labs/smlib@c5b6bb7, smlib#101, merged at 852dd8c).
1545
-
pub fillet_round_on_round_as_definition:bool,
1546
1544
/// With `fillet_cliff_overflow` (and its prerequisites), a blend past its faces is trimmed at its creases where it is built instead of being closed into the region it removes and subtracted (the fork's `SmFilletExecutive::TrimAtCreases`, `SmFilletOverflow.cpp`, tangency-labs/smlib#79 step 6 at 5e8c9c1, which deletes `SubtractRemovalRegion`): the open ends are cut by their end faces' planes as before; each sheet face is sectioned by every body face near it that holds none of its boundary, exactly by a plane, and split along each crease where it lies inside both faces; a piece is kept only when its inner point lies inside the body; a planar support face whose kept rail runs past its boundary into the material is carried on along its plane to the rail; the kept sheet's boundary is imprinted on the body's faces, the faces it encloses round the blended edges are deleted, the sheet is merged in and stitched, the body oriented, and the edges between faces sewn in on one surface removed. The blend keeps its radius and the sharp edge moves. Refused with `FilletErrorType::NoRoom`: a crease on a face that runs on tangentially from a face the blend rolls on (`NoRoomReason::CreaseAcrossTangentEdge`), a blend whose corners take its whole edge (`CornersTakeWholeEdge`), and a rail into the material that the support face cannot be carried on to (`RailRunsPastFaceIntoMaterial`); `BadMerge` for a sheet that does not sew into a manifold solid. Off: the subtraction, as before (WR-695, #2273).
1547
1545
pub fillet_overflow_trim_at_creases:bool,
1548
1546
/// With both `fillet_overflow_trim_at_creases` and `fillet_round_ends_at_tangent_continuation`, a round with a section end (WR-674: its filleted edge runs on tangentially at the vertex) is trimmed at its creases and sewn into the body as a cliff overflow is, instead of being closed into the region it removes and subtracted: each section end is cut by its plane through the vertex normal to the filleted edge and given its flat end face (the section's corner, from the section's ends to the vertex), and the sheet is trimmed and sewn in as `fillet_overflow_trim_at_creases` does it; a side of an end face that lies along an edge of the body (the seam where a corner's cylinder runs on tangentially into a flat side) is sewn to that edge's piece instead of being imprinted. So a round with a section end is built together with other rounds (an R25 rim and an R2 corner arc of a tabbed plate rounded together, which the subtraction refuses with `FilletErrorType::NoRoom`: it builds only a lone round both of whose ends are section ends). Off: the subtraction, as before (WR-706, #2223; own design, not in the fork, which at 5e8c9c1 leaves such a corner arc unrounded).
"{} round(s) on a round by definition, {} spans: sections off the ball's circle by {:.3e}, the net at {:.3} of its bound; {} definition evaluations, {} station solves; the rail crosses the inner round's stations {} times, {} without a station of its own",
422
-
o.graded,
423
-
o.spans,
424
-
o.circle,
425
-
o.net,
426
-
o.counts.evaluations,
427
-
o.counts.solves,
428
-
o.crossings,
429
-
o.missed
430
-
);
431
-
assert!(o.sound,"{o:?}");
432
-
assert_eq!(o.graded,0,"{o:?}");
433
-
}
434
-
435
411
/// The net `net` with its distinct inner knot `kv` along s taken out (every copy of it),
436
412
/// one control row fewer per copy: the net a knot removal leaves. Only its knots along s
437
413
/// are read by the enclosure of its definition (they name the piece whose station seeds
0 commit comments