Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SubscribeToPresence publisher worker should fail trackable if channel attach fails #1043

Open
AndyTWF opened this issue Mar 27, 2023 · 1 comment
Open

SubscribeToPresence publisher worker should fail trackable if channel attach fails #1043

AndyTWF opened this issue Mar 27, 2023 · 1 comment
Labels
bug Something isn't working. It's clear that this does need to be fixed.

Comments

@AndyTWF
Copy link
Contributor

AndyTWF commented Mar 27, 2023

At the moment, the EnterPresenceWorker fails the trackable if the channel attach fails (enters a FAILED state) whilst the worker is waiting. This allows the consumer to decide what to do next. However SubscribeToPresenceWorker does not, we should fail the trackable in this instance for consistency.
@AndyTWF AndyTWF added the bug Something isn't working. It's clear that this does need to be fixed. label Mar 27, 2023
@sync-by-unito
Copy link

sync-by-unito bot commented Mar 27, 2023

➤ Automation for Jira commented:

The link to the corresponding Jira issue is https://ably.atlassian.net/browse/SDK-3482

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working. It's clear that this does need to be fixed.
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AndyTWF