Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proguard has been disabled for the integration-testing-app project, rendering the ObfuscationTest impotent #926

Open
QuintinWillison opened this issue Jan 19, 2023 · 2 comments
Open

Proguard has been disabled for the integration-testing-app project, rendering the ObfuscationTest impotent #926

QuintinWillison opened this issue Jan 19, 2023 · 2 comments
Labels
code-quality Affects the developer experience when working in our codebase. testing Includes all kinds of automated tests, the way that we run them and the infrastructure around them.

Comments

@QuintinWillison
Copy link
Contributor

QuintinWillison commented Jan 19, 2023 •
edited by sync-by-unito bot
Loading

It was disabled in #915 in order to get #886 over the line.

For further context, see @KacperKluka's review comment.
@QuintinWillison QuintinWillison added code-quality Affects the developer experience when working in our codebase. testing Includes all kinds of automated tests, the way that we run them and the infrastructure around them. labels Jan 19, 2023
@QuintinWillison QuintinWillison mentioned this issue Jan 19, 2023
Merged
@sync-by-unito
Copy link

sync-by-unito bot commented Jan 19, 2023

➤ Automation for Jira commented:

The link to the corresponding Jira issue is https://ably.atlassian.net/browse/SDK-3261

@KacperKluka
Copy link
Contributor

For context:
The main reason behind enabling the Proguard in the integration-testing-app module was to catch bugs related to our Proguard configuration as soon as possible. It was triggered by #396 and added in #408.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code-quality Affects the developer experience when working in our codebase. testing Includes all kinds of automated tests, the way that we run them and the infrastructure around them.
Milestone
No milestone
Development

No branches or pull requests
2 participants
@QuintinWillison @KacperKluka