Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subscriber Worker Queue: Change Resolution #584

Open
AndyTWF opened this issue Feb 22, 2023 · 2 comments
Open

Subscriber Worker Queue: Change Resolution #584

AndyTWF opened this issue Feb 22, 2023 · 2 comments
Milestone

Comments

@AndyTWF
Copy link
Contributor

AndyTWF commented Feb 22, 2023

Implement the following workers for the Subscriber:

  • ChangeResolution
  • ChangeResolutionSuccess

ChangeResolution is enqueued from the subscriber when the libraries consumer wishes to set a resolution preference for the subscriber. The logic of changing resolution is essentially identical to that of: #566, except the fact that ChangeResolutionSuccess work is posted upon completion.

@sync-by-unito
Copy link

sync-by-unito bot commented Feb 22, 2023

➤ Automation for Jira commented:

The link to the corresponding Jira issue is https://ably.atlassian.net/browse/SDK-3402

@lawrence-forooghian
Copy link
Collaborator

lawrence-forooghian commented Feb 23, 2023

@AndyTWF I think that ChangeResolutionSuccess only exists in the publisher SDK – in the subscriber SDK it directly calls the callback function. Actually, I can't see ChangeResolutionSuccess at all – where does that come from?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants