Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide a better way to pull in the stuff that’s currently Git submodules #646

Open
lawrence-forooghian opened this issue Apr 13, 2023 · 1 comment
Labels
build Relates to the tooling used to build or release the contents of this repository.

Comments

@lawrence-forooghian
Copy link
Collaborator

The external/common and external/sdk-test-proxy directories are currently Git submodules. This means that when a user installs the SDKs using Swift Package Manager it will clone these repositories. However, this repositories are only development dependencies, and it doesn't seem like a good idea to impose this overhead on users.

Perhaps it would be better to have a script that clones these repos for development instead.

We should then update the guidance in https://github.com/ably/ably-asset-tracking-common/tree/e5cd278a910a287a04a91e4b320a3079287fc31f#usage-in-downstream-repositories.

@lawrence-forooghian lawrence-forooghian added the build Relates to the tooling used to build or release the contents of this repository. label Apr 13, 2023
@sync-by-unito
Copy link

sync-by-unito bot commented Apr 13, 2023

➤ Automation for Jira commented:

The link to the corresponding Jira issue is https://ably.atlassian.net/browse/SDK-3528

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Relates to the tooling used to build or release the contents of this repository.
Development

No branches or pull requests

1 participant