From e6177a4b039ef0d08224be5d4c73e9cddce05502 Mon Sep 17 00:00:00 2001 From: sacOO7 Date: Tue, 23 Jul 2024 19:33:08 +0530 Subject: [PATCH] Set env variable to be job level instead of global --- .github/workflows/check.yml | 6 +++--- .github/workflows/integration-test.yml | 7 +++---- 2 files changed, 6 insertions(+), 7 deletions(-) diff --git a/.github/workflows/check.yml b/.github/workflows/check.yml index 548ce15f..1cbdfd93 100644 --- a/.github/workflows/check.yml +++ b/.github/workflows/check.yml @@ -1,8 +1,5 @@ # Based upon: # https://github.com/actions/starter-workflows/blob/main/ci/go.yml -env: - HTTP_PROXY: http://ably:AbLyProxy22@45.11.26.133:7128 - HTTPS_PROXY: https://ably:AbLyProxy22@45.11.26.133:7128 on: pull_request: @@ -45,6 +42,9 @@ jobs: run: go install github.com/jstemmer/go-junit-report@latest - name: Unit Tests + env: + HTTP_PROXY: http://ably:AbLyProxy22@45.11.26.133:7128 + HTTPS_PROXY: https://ably:AbLyProxy22@45.11.26.133:7128 run: | set -o pipefail echo "proxy is $HTTP_PROXY" diff --git a/.github/workflows/integration-test.yml b/.github/workflows/integration-test.yml index 394b9820..ffdc6e34 100644 --- a/.github/workflows/integration-test.yml +++ b/.github/workflows/integration-test.yml @@ -1,7 +1,3 @@ -env: - HTTP_PROXY: http://ably:AbLyProxy22@45.11.26.133:7128 - HTTPS_PROXY: https://ably:AbLyProxy22@45.11.26.133:7128 - on: pull_request: push: @@ -35,6 +31,9 @@ jobs: run: go install github.com/jstemmer/go-junit-report@latest - name: Integration Tests with ${{ matrix.protocol }} Protocol + env: + HTTP_PROXY: http://ably:AbLyProxy22@45.11.26.133:7128 + HTTPS_PROXY: https://ably:AbLyProxy22@45.11.26.133:7128 run: | echo "proxy is $HTTP_PROXY" set -o pipefail