Skip to content

Commit 1913aa3

Browse files
umair-ablyclaude
andcommitted
Drop DR/ticket numbers from code comments
Comments describe the behavior in place (versionless registry entries, the load-bearing suffix) rather than citing decision-record or PR numbers; those references live in the PR descriptions and READMEs. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
1 parent 42d3bd3 commit 1913aa3

3 files changed

Lines changed: 5 additions & 5 deletions

File tree

‎device/src/androidTest/java/io/ably/pubsub/device/PubSubDeviceTest.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
* MAU-priced accounts, so these tests are deliberately strict: if one fails, billing
1818
* classification is broken, not just a header.
1919
* <p>
20-
* The side entry is a versionless flag — a bare token on the wire, per ably/ably-common#361
20+
* The side entry is a versionless flag — a bare token on the wire, registered as such in the ably-common agents registry
2121
* — so the assertions also fail if a version (or any {@code /suffix}) reappears on it.
2222
*/
2323
public class PubSubDeviceTest {

‎server/src/test/java/io/ably/pubsub/server/PubSubServerTest.java‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
* MAU-priced accounts, what earns the server exemption), so these tests are deliberately
2828
* strict: if one fails, billing classification is broken, not just a header.
2929
* <p>
30-
* The side entry is a versionless flag — a bare token on the wire, per ably/ably-common#361
30+
* The side entry is a versionless flag — a bare token on the wire, registered as such in the ably-common agents registry
3131
* — so the assertions also fail if a version (or any {@code /suffix}) reappears on it.
3232
*/
3333
public class PubSubServerTest {
@@ -149,7 +149,7 @@ public void httpRequests_carryTheServerAgentHeaderOnTheWire() throws Exception {
149149
assertNotNull("no Ably-Agent header observed", agentHeader);
150150
List<String> tokens = Arrays.asList(agentHeader.split(" "));
151151
// The flag must be present as a bare token: `name/anything` means the
152-
// versionless stamp regressed (see ably/ably-common#361).
152+
// versionless stamp regressed (the registry entry is versionless).
153153
assertTrue("missing bare side flag in: " + agentHeader,
154154
tokens.contains(Side.SERVER_AGENT_IDENTIFIER));
155155
assertFalse("side flag must be versionless in: " + agentHeader,

‎shared/src/main/java/io/ably/pubsub/internal/Side.java‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
* rather than published, so that the two artifacts can share this code without a third
1313
* artifact existing for it to live in.
1414
* <p>
15-
* PDR-091 keeps {@code io.ably.pubsub:core} itself as the shared core, so nothing here may
15+
* The package split keeps {@code io.ably.pubsub:core} itself as the shared core, so nothing here may
1616
* grow into a general abstraction over the core: it exists only to stamp the side a package
1717
* declares.
1818
*/
@@ -47,7 +47,7 @@ private Side() {}
4747
* <p>
4848
* The side entry is a <em>versionless flag</em> — a bare token on the wire, like the
4949
* platform's own {@code browser} entry — registered as such in the ably-common agents
50-
* registry (see ably/ably-common#361). Identity, version and support status keep
50+
* registry. Identity, version and support status keep
5151
* travelling on the SDK's own {@code ably-pubsub-java/<version>} entry alongside it;
5252
* {@link io.ably.lib.util.AgentHeaderCreator} emits a map entry with a {@code null}
5353
* value as a bare token.

0 commit comments

Comments
 (0)