You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit dced517
Browse filesBrowse the repository at this point in the historyBrowse files
Give the door builders an options-accepting entry point
The device and server doors exposed only no-arg fluent builders, but the
branch's own callers — the UTS ClientFactories seam and the device
instrumentation test — call realtimeClientBuilder(options),
httpClientBuilder(options) and clientBuilder(options). That mismatch broke
:uts:compileKotlin and :device:compileDebugAndroidTestJavaWithJavac, and
with them every CI job that builds either module.
The fluent setters cannot express a pre-assembled DebugOptions
(transportFactory, webSocketEngineFactory, clock), so the UTS server leg has
to hand the door an options object rather than replay it setter by setter.
Each door gains one overload taking ClientOptions, and the builder wraps that
object instead of its own empty one, so a DebugOptions subclass and its mock
transports reach the client intact. A key or token still goes through the
builder's own key()/token() setter: there is no key-string overload.
Also drops shared/src/main/java/io/ably/pubsub/internal/Side.java, a second
copy of the side-stamping helper that no module compiled — settings.gradle.kts
never included it and no source set added it as a srcDir, so
io.ably.lib.util.Side is the one the doors actually use. The two references to
the dead class, SideModesTest's import and a Defaults javadoc pointer, now name
the surviving one. The instrumentation test asserts non-mutation the way
PubSubServerTest does, on the caller's agents map rather than on the identity
of options.agents, because build() stamps that field in place.
:device had no androidTest dependencies at all, so add JUnit, a runner and the
testInstrumentationRunner the emulator matrix needs.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
0 commit comments