Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decide on naming for imports. #52

Open
Morganamilo opened this issue Aug 24, 2022 · 1 comment
Open

Decide on naming for imports. #52

Morganamilo opened this issue Aug 24, 2022 · 1 comment
Labels
code-quality Affects the developer experience when working in our codebase.

Comments

@Morganamilo
Copy link

Morganamilo commented Aug 24, 2022 •
edited by sync-by-unito bot
Loading

Both control and the terraform imports have quite generic names. Is it best to import them how they are named or rename them to something more detailed?

control is rather generic but should be rather obvious in the context of the code I thin. provider should be too but it may conflict with variables? Maybe we should see what other projects do.

┆Issue is synchronized with this Jira Task by Unito
@sync-by-unito
Copy link

sync-by-unito bot commented Nov 24, 2022

➤ Automation for Jira commented:

The link to the corresponding Jira issue is https://ably.atlassian.net/browse/SDK-3046

@QuintinWillison QuintinWillison added the code-quality Affects the developer experience when working in our codebase. label Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code-quality Affects the developer experience when working in our codebase.
Milestone
No milestone
Development

No branches or pull requests
2 participants
@QuintinWillison @Morganamilo