(nameRegistry): check short name is not zero

aboutcircles · Oct 1, 2024 · 3954035 · 3954035
1 parent 74a6435
commit 3954035
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/src/errors/Errors.sol b/src/errors/Errors.sol
@@ -95,4 +95,6 @@ interface INameRegistryErrors {
     error CirclesNamesAvatarAlreadyHasCustomNameOrSymbol(address avatar, string nameOrSymbol, uint8 code);
 
     error CirclesNamesOrganizationHasNoSymbol(address organization, uint8 code);
+
+    error CirclesNamesShortNameZero(address avatar, uint256 nonce);
 }
diff --git a/src/names/NameRegistry.sol b/src/names/NameRegistry.sol
@@ -292,6 +292,11 @@ contract NameRegistry is Base58Converter, INameRegistry, INameRegistryErrors, IC
     }
 
     function _storeShortName(address _avatar, uint72 _shortName, uint256 _nonce) internal {
+        if (_shortName == uint72(0)) {
+            // short name cannot be zero (but congrats if you got it!)
+            // this would break the reverse lookup
+            revert CirclesNamesShortNameZero(_avatar, _nonce);
+        }
         // assign the name to the address
         shortNames[_avatar] = _shortName;
         // assign the address to the name