Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It may make sense to implement the extractors that can be implemented using python bindings only or purely in python that way #26

Open
KOLANICH opened this issue Jun 24, 2021 · 1 comment

Comments

@KOLANICH
Copy link

It would avoid a possible security issue with calling a subprocess and also may allow progress reporting (i.e. https://github.com/prebuilder/fetchers.py/blob/master/fetchers/unpackers/archives/tar.py#L24).

pombredanne added a commit that referenced this issue Oct 8, 2021
Create junction from Scripts to bin
@pombredanne
Copy link
Member

@KOLANICH Thank you for the report. We only use 7zip as a subprocess and there is no easy way to use this as a library AFAIK. In general we are using either the Python stdlib, pure python code or a libarchive Ctypes binding AND 7zip.
There are archives that can be extracted reliably only with 7zip so I am not really inclined to drop it as at the scale this tool is being used it would be a problem (there are billions of archives that have been extracted with this code)

That said, we could have a degraded mode where 7zip and/or libarchive are optional and not always installed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants