Skip to content

Commit bf12905

Browse files
Merge pull request #22903 from abpframework/salihozkara/docs-pdf
Fix: pdf generation
2 parents e3caaf7 + 7822f6a commit bf12905

File tree

2 files changed

+23
-3
lines changed

2 files changed

+23
-3
lines changed

modules/docs/src/Volo.Docs.Admin.Web/Pages/Docs/Admin/Projects/GeneratePdf.cshtml.cs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,18 +13,15 @@ namespace Volo.Docs.Admin.Pages.Docs.Admin.Projects;
1313

1414
public class GeneratePdfModal : DocsAdminPageModel
1515
{
16-
protected IDocumentPdfGeneratorAppService DocumentPdfGeneratorAppService { get; }
1716
protected IProjectAppService ProjectAppService { get; }
1817
protected IProjectAdminAppService ProjectAdminAppService { get; }
1918

2019
public GeneratePdfViewModel ViewModel { get; set; }
2120

2221
public GeneratePdfModal(
23-
IDocumentPdfGeneratorAppService documentPdfGeneratorAppService,
2422
IProjectAppService projectAppService,
2523
IProjectAdminAppService projectAdminAppService)
2624
{
27-
DocumentPdfGeneratorAppService = documentPdfGeneratorAppService;
2825
ProjectAppService = projectAppService;
2926
ProjectAdminAppService = projectAdminAppService;
3027
}

modules/docs/src/Volo.Docs.Common.Application/Volo/Docs/Common/Documents/DocumentPdfGeneratorAppService.cs

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,9 @@
1+
using System.Text;
12
using System.Threading.Tasks;
23
using Microsoft.AspNetCore.Authorization;
34
using Volo.Abp.Application.Services;
45
using Volo.Abp.Content;
6+
using Volo.Abp.Data;
57
using Volo.Docs.Projects;
68
using Volo.Docs.Projects.Pdf;
79

@@ -24,6 +26,27 @@ public DocumentPdfGeneratorAppService(
2426
public virtual async Task<IRemoteStreamContent> GeneratePdfAsync(DocumentPdfGeneratorInput input)
2527
{
2628
var project = await ProjectRepository.GetAsync(input.ProjectId, includeDetails: true);
29+
30+
// https://github.com/abpframework/abp/blob/e96f601641ab8a4bb7d704d3b9df2c00517d96f6/modules/docs/src/Volo.Docs.Application/Volo/Docs/Documents/DocumentAppService.cs#L73
31+
var inputVersionStringBuilder = new StringBuilder();
32+
input.Version = inputVersionStringBuilder.Append(GetProjectVersionPrefixIfExist(project)).Append(input.Version).ToString();
2733
return await ProjectPdfGenerator.GenerateAsync(project, input.Version, input.LanguageCode);
2834
}
35+
36+
private string GetProjectVersionPrefixIfExist(Project project)
37+
{
38+
if (GetGithubVersionProviderSource(project) != GithubVersionProviderSource.Branches)
39+
{
40+
return string.Empty;
41+
}
42+
43+
return project.GetProperty<string>("VersionBranchPrefix");
44+
}
45+
46+
private GithubVersionProviderSource GetGithubVersionProviderSource(Project project)
47+
{
48+
return project.HasProperty("GithubVersionProviderSource")
49+
? project.GetProperty<GithubVersionProviderSource>("GithubVersionProviderSource")
50+
: GithubVersionProviderSource.Releases;
51+
}
2952
}

0 commit comments

Comments
 (0)