helm upgrade not looking up runfiles correctly

[ellie-idb]

Hey there! I'm using rules_helm in a work project, and I noticed that there's an issue when using helm upgrade to automatically push the image. The wrapper script will fail with:

; bazelisk run //helm/hydra:chart.install.preproduction
INFO: Analyzed target //helm/hydra:chart.install.preproduction (1 packages loaded, 15 targets configured).
INFO: Found 1 target...
Target //helm/hydra:chart.install.preproduction up-to-date:
  bazel-bin/helm/hydra/chart.install.preproduction.sh
INFO: Elapsed time: 0.186s, Critical Path: 0.02s
INFO: 2 processes: 2 internal.
INFO: Build completed successfully, 2 total actions
INFO: Running command line: bazel-bin/helm/hydra/chart.install.preproduction.sh
/home/ellie/.cache/bazel/_bazel_ellie/9eacc77f2aa12fa1a5e4c4878a0e0dc6/execroot/_main/bazel-out/k8-fastbuild/bin/helm/hydra/chart.install.preproduction.sh: line 11: push_image.push.sh: command not found

I digged into this a little more, and "push_image.push.sh" doesn't exist in the same directory as the script:

; ls /home/ellie/.cache/bazel/_bazel_ellie/9eacc77f2aa12fa1a5e4c4878a0e0dc6/execroot/_main/bazel-out/k8-fastbuild/bin/helm/hydra
chart                           chart.install.preproduction.sh.repo_mapping  chart.install.preproduction.sh.runfiles_manifest  chart.tgz        chart_yaml.yaml
chart.install.preproduction.sh  chart.install.preproduction.sh.runfiles      chart.metadata.json                               chart_yaml.json  
;

... but it does exist in the working directory of the script, which is set to /home/ellie/.cache/bazel/_bazel_ellie/9eacc77f2aa12fa1a5e4c4878a0e0dc6/execroot/_main/bazel-out/k8-fastbuild/bin/helm/hydra/chart.install.preproduction.sh.runfiles/_main:

; ls /home/ellie/.cache/bazel/_bazel_ellie/9eacc77f2aa12fa1a5e4c4878a0e0dc6/execroot/_main/bazel-out/k8-fastbuild/bin/helm/hydra/chart.install.preproduction.sh.runfiles/_main
_tags.txt  helm  image  image.tar.tar  push_image.push.sh  stable-status.txt  volatile-status.txt

I think the culprit here is this line:

rules_helm/helm/private/helm_install.bzl

Line 149 in a655ce5

"{EXTRA_CMDS}": "\n".join([pusher.short_path for pusher in image_pushers]),

as changing this line to be:

            "{EXTRA_CMDS}": "\n".join([". {}".format(pusher.short_path) for pusher in image_pushers]),

makes this issue go away. I'm not sure if this is the way that it's meant to be fixed, rather something that I found while trying to fix it.