Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: "see" in commit message results in "closes" in changelog #189

Open
davidsneighbour opened this issue Sep 20, 2024 · 1 comment
Open
Labels
bug Something isn't working

Comments

@davidsneighbour
Copy link

My commit message:

git commit -m "chore(config): add dnbhub.xyz to connect-src and img-src in CSP

see #1211"

Running commit-and-tag-version:

RELEASE_NOTES="$(npx commit-and-tag-version --dry-run | awk 'BEGIN { flag=0 } /^---$/ { if (flag == 0) { flag=1 } else { flag=2 }; next } flag == 1')"
echo "${RELEASE_NOTES}" > changes.md

(it's an excellent way to have my changelog in the pre-release hook)

The changelog:

## [2024.5.6](https://github.com/davidsneighbour/kollitsch.dev/compare/v2024.5.5...v2024.5.6) (2024-09-20)


### Chore

* **config:** add dnbhub.xyz to connect-src and img-src in CSP ([0d38925](https://github.com/davidsneighbour/kollitsch.dev/commit/0d3892588e4ff49597d52404baad134c8fb9d0cc)), closes [#1211](https://github.com/davidsneighbour/kollitsch.dev/issues/1211)

Expected result:

Not sure why it replaces the see with closes. It should take whatever verb I am using, or at least the available verbs for autolinking in Github. see results in a link to the issue without closing it and works on the commit.

@davidsneighbour davidsneighbour added the bug Something isn't working label Sep 20, 2024
@TimothyJones
Copy link
Member

Thanks for the report! I agree with you, this isn’t ideal or expected behaviour. Unfortunately, the problem isn’t in this repository, it’s in one of the conventional changelog dependencies. I’m travelling at the moment, so it’s not easy to find out which one, but I’ll comment back in a week or so if I haven’t heard back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants