You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Current behavior
No commits are listed in the generated CHANGELOG.md
Expected behavior
Commits are listed in the generated CHANGELOG.md
Environment
commit-and-tag-version version(s): 12.5.0
Node/npm version: Node v20.18.1, NPM v10.8.2
OS: Ubuntu 22.04.5 LTS (Github Actions runner)
Possible Solution
Hopefully updating conventional-changelog to something new-ish (currently used version is 4.0.0 while the newest version seems to be 6.0.0 according to npmjs.com) would help? I haven't tried this.
Looking at the current master version of conventional-changelog:
writer has been substantially rewritten and the closest code seems to be here, though it looks like it has the same bug. Maybe I'm missing some promisification happening elsewhere.
Additional context
I'm using commit-and-tag-version from within [email protected]. It lists
"commit-and-tag-version": "^12",
as a dependency automatically for all TS projects.
The text was updated successfully, but these errors were encountered:
Just realized that perhaps I don't have the full story here because the transform fn from mergeOptions doesn't even get run. So maybe it's a red herring
Describe the bug
[email protected]
creates a CPS-styletransform
function (never returns, callscb(null, commit)
)[email protected]
tries to use it in a non-CPS style (commit = transform(commit, context)
, resulting incommit
being null)commits
is given to the CHANGELOG.md generator, and that returnswithout any commits listed.
Current behavior
No commits are listed in the generated CHANGELOG.md
Expected behavior
Commits are listed in the generated CHANGELOG.md
Environment
commit-and-tag-version
version(s):12.5.0
Possible Solution
Hopefully updating
conventional-changelog
to something new-ish (currently used version is4.0.0
while the newest version seems to be6.0.0
according to npmjs.com) would help? I haven't tried this.Looking at the current
master
version ofconventional-changelog
:core
still uses CPS in mergeConfigwriter
has been substantially rewritten and the closest code seems to be here, though it looks like it has the same bug. Maybe I'm missing some promisification happening elsewhere.Additional context
I'm using
commit-and-tag-version
from within[email protected]
. It listsas a dependency automatically for all TS projects.
The text was updated successfully, but these errors were encountered: