Fix Race and add more benchmark tests (#11)

* reverse iterator init * some fixes * fix reverse iterator seaklowerbound * fix tests * fix track channels * longest prefix on txn * some fixes * revisit * todo revisit * major code refactor * some minor fixes * add lru * fix bugs * added walk func * add more tests * some prog * some progress track mutate * some progress * fix tests * some optimizations * some memory optimizations * fix tests * minor fixes * some minor fixes * some fixes * fix delete prefix * some fixes * init stack * fix seek lower bound * clone * fix watch * fix clone bug * some fixes for go mem db * merge absl * Fix race * fix go mod * fix race in add child
absolutelightning · May 21, 2024 · 643e521 · 643e521
1 parent d097dd7
commit 643e521
Show file tree

Hide file tree

Showing 2 changed files with 31 additions and 7 deletions.
diff --git a/tree_test.go b/tree_test.go
@@ -1158,22 +1158,45 @@ func BenchmarkMixedOperations(b *testing.B) {
 			// Randomly choose an operation
 			switch rand.Intn(3) {
 			case 0:
-				art.Insert([]byte(key), j)
+				art, _, _ = art.Insert([]byte(key), j)
 			case 1:
 				art.Get([]byte(key))
 			case 2:
-				art.Delete([]byte(key))
+				art, _, _ = art.Delete([]byte(key))
 			}
 		}
 	}
 }
 
+func BenchmarkGroupedOperations(b *testing.B) {
+	dataset := generateDataset(datasetSize)
+	art := NewRadixTree[int]()
+
+	b.ResetTimer()
+	for i := 0; i < b.N; i++ {
+		// Insert all keys
+		for _, key := range dataset {
+			art, _, _ = art.Insert([]byte(key), 0)
+		}
+
+		// Search all keys
+		for _, key := range dataset {
+			art.Get([]byte(key))
+		}
+
+		// Delete all keys
+		for _, key := range dataset {
+			art, _, _ = art.Delete([]byte(key))
+		}
+	}
+}
+
 func BenchmarkInsertART(b *testing.B) {
 	r := NewRadixTree[int]()
 	b.ResetTimer()
 	for n := 0; n < b.N; n++ {
 		uuid1, _ := uuid.GenerateUUID()
-		r.Insert([]byte(uuid1), n)
+		r, _, _ = r.Insert([]byte(uuid1), n)
 	}
 }
 
@@ -1182,7 +1205,7 @@ func BenchmarkSearchART(b *testing.B) {
 	b.ResetTimer()
 	for n := 0; n < b.N; n++ {
 		uuid1, _ := uuid.GenerateUUID()
-		r.Insert([]byte(uuid1), n)
+		r, _, _ = r.Insert([]byte(uuid1), n)
 		r.Get([]byte(uuid1))
 	}
 }
@@ -1192,7 +1215,7 @@ func BenchmarkDeleteART(b *testing.B) {
 	b.ResetTimer()
 	for n := 0; n < b.N; n++ {
 		uuid1, _ := uuid.GenerateUUID()
-		r.Insert([]byte(uuid1), n)
-		r.Delete([]byte(uuid1))
+		r, _, _ = r.Insert([]byte(uuid1), n)
+		r, _, _ = r.Delete([]byte(uuid1))
 	}
 }
diff --git a/txn.go b/txn.go
@@ -149,7 +149,8 @@ func (t *Txn[T]) recursiveInsert(node Node[T], key []byte, value T, depth int, o
 			depth += int(node.getPartialLen())
 			child, idx := t.findChild(node, key[depth])
 			if child != nil {
-				newChild, val := t.recursiveInsert(child, key, value, depth+1, old)
+				newChildChClone := t.writeNode(child)
+				newChild, val := t.recursiveInsert(newChildChClone, key, value, depth+1, old)
 				node.setChild(idx, newChild)
 				if t.trackMutate {
 					t.trackChannel(node.getMutateCh())