Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FulFillmentInboundServicev20240320.ListTransportationOptionsAsync fails to map paginationToken and retrieve pages properly #786

Open
dmelendez35 opened this issue Oct 29, 2024 · 3 comments

Comments

@dmelendez35
Copy link
Contributor

dmelendez35 commented Oct 29, 2024

I noticed this method returned me like 400 records, exactly 20 pages of 20 records, and a lot of repeated options, so I debug it and noticed that the class "ParameterListTransportationOptions" have 2 properties with cammel case: "placementOptionId" and "shipmentId" and 1 property in Pascal case "PaginationToken" so I suspected that the process did not mapped the token and therefore it got into a cycle of getting alway the page 1 until it reached 20 times, wich is the default maximum pages.

So, I created my own parameter class renaming to "paginationToken" (cammel case), inherited a service to use my model and it worked!, I got now 92 records with no repetiton.

So could you look into this issue?, check if this is a good solution so I can avoid having inheritances and additional models,
thanks

@dmelendez35
Copy link
Contributor Author

Isue fixed and merged to master

@memotronics
Copy link

Hi demelendez, I came to the same conclusion (that there was an issue with paginationtoken).
You fixed this in ListTranportaionOptions, but wouldn't this issue be on all the other paginated lists as well, like ParameterListInboundPlans etc.?

@dmelendezhikrutech
Copy link

Hi @memotronics , I planning on a more general fix, I'll implement it in #795

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants