Merge pull request #203 from accordproject/dl-update-isEditable

refactor(*): pass editor to isEditable so it can be used by plugins

Author: DianaLease

package-lock.json

@@ -112,4 +112,4 @@
     "slate-plain-serializer": "^0.7.10",
     "style-loader": "^0.23.1"
   }
-}
+}

package.json

@@ -175,9 +175,8 @@ export default class FormatToolbar extends React.Component {
    */
   onClickMark(event, type) {
     const { editor, pluginManager, lockText } = this.props;
-    const { value } = editor;
 
-    if (!lockText || pluginManager.isEditable(value, type)) {
+    if (!lockText || pluginManager.isEditable(editor, type)) {
       event.preventDefault();
       editor.toggleMark(type);
     }
@@ -189,8 +188,7 @@ export default class FormatToolbar extends React.Component {
    */
   onClickLinkButton() {
     const { editor, pluginManager, lockText } = this.props;
-    const { value } = editor;
-    if (!lockText || pluginManager.isEditable(value)) {
+    if (!lockText || pluginManager.isEditable(editor)) {
       const hasLinksBool = action.hasLinks(editor);
       const isOnlyLinkBool = action.isOnlyLink(editor);
       if (hasLinksBool && !isOnlyLinkBool) return;
@@ -212,7 +210,7 @@ export default class FormatToolbar extends React.Component {
     const { editor, pluginManager, lockText } = this.props;
     const { value } = editor;
 
-    if (!lockText || pluginManager.isEditable(value, type)) {
+    if (!lockText || pluginManager.isEditable(editor, type)) {
       event.preventDefault();
       if (action.isClickBlockQuote(type)) {
         action.isSelectionList(value)

src/FormattingToolbar/index.js

@@ -57,16 +57,16 @@ export default class PluginManager {
    * If any plugin returns isEditable (true) then
    * the content is editable
    *
-   * @param {Value} value the Slate value
+   * @param {Editor} editor the Slate editor
    * @param {string} code the type of edit requested
    */
-  isEditable(value, code) {
+  isEditable(editor, code) {
     // if no plugins have an `isEditable` method, return true
     if (!this.plugins.filter(plugin => plugin.isEditable).length) return true;
 
     for (let n = 0; n < this.plugins.length; n += 1) {
       const plugin = this.plugins[n];
-      if (plugin.isEditable && plugin.isEditable(value, code)) {
+      if (plugin.isEditable && plugin.isEditable(editor, code)) {
         return true;
       }
     }

src/PluginManager.js

@@ -232,9 +232,8 @@ const SlateAsInputEditor = React.forwardRef((props, ref) => {
   */
   const isEditable = useCallback((editor, code) => {
     if (editor.props.lockText) {
-      const { value } = editor;
       const pluginManager = new PluginManager(plugins);
-      return pluginManager.isEditable(value, code);
+      return pluginManager.isEditable(editor, code);
     }
 
     return true;