Improve naming

Author: acdvs

lib/rules/module-vars.js

@@ -1,7 +1,7 @@
 'use strict';
 
 const moduleUtil = require('../util/modules');
-const { MODULE_NAMES } = require('../util/modules');
+const { moduleNames } = require('../util/modules');
 
 module.exports = {
   meta: {
@@ -50,7 +50,7 @@ module.exports = {
  * @returns {Object}
  */
 function getSchemaProperties() {
-  let properties = MODULE_NAMES.map((name) => {
+  let properties = moduleNames.map((name) => {
     return {
       [name]: {
         type: 'string',

lib/util/modules.js

@@ -54,7 +54,8 @@ const MODULES = {
   'N/workflow': 'workflow',
   'N/xml': 'xml',
 };
-const MODULE_NAMES = Object.keys(MODULES);
+
+const moduleNames = Object.keys(MODULES);
 
 /**
  * Maps the define callback params to the module array
@@ -110,7 +111,7 @@ function getModules(defineCallNode) {
         },
         isValid:
           !!nameNode &&
-          (MODULE_NAMES.includes(nameNode.value) || !N_MODULE_REGEX.test(nameNode.value)),
+          (moduleNames.includes(nameNode.value) || !N_MODULE_REGEX.test(nameNode.value)),
       });
     }
   }
@@ -157,7 +158,7 @@ function getModuleNodePair(defineCallNode, moduleName) {
 
 module.exports = {
   MODULES,
-  MODULE_NAMES,
+  moduleNames,
   getModules,
   getModuleNames,
   getModuleVars,

scripts/generate_docs.js

@@ -1,7 +1,7 @@
 const fs = require('fs');
 const path = require('path');
-const { MODULE_NAMES } = require('./../lib/util/modules');
-const { scriptTypeMap } = require('./../lib/util/scriptTypes');
+const { moduleNames } = require('./../lib/util/modules');
+const { scriptTypes } = require('./../lib/util/script-types');
 
 const SRC_DIR = './docs/src';
 const OUT_DIR = './docs/rules';
@@ -10,23 +10,23 @@ const SCRIPT_NAME = path.basename(__filename);
 const docsToModify = {
   'entry-points.md': {
     old: '<ENTRY_POINTS>',
-    new: Object.entries(scriptTypeMap).reduce((str, [scriptType, st]) => {
-      str += `- ${scriptType}\n`;
-      st.entryPoints.forEach((ep) => (str += `  - ${ep}\n`));
+    new: scriptTypes.reduce((str, x) => {
+      str += `- ${x.name}\n`;
+      x.entryPoints.forEach((ep) => (str += `  - ${ep}\n`));
       return str;
     }, ''),
   },
   'module-vars.md': {
     old: '<MODULE_NAMES>',
-    new: MODULE_NAMES.reduce((str, x) => {
+    new: moduleNames.reduce((str, x) => {
       str += `- ${x}\n`;
       return str;
     }, ''),
   },
   'script-type.md': {
     old: '<SCRIPT_TYPES>',
-    new: Object.keys(scriptTypeMap).reduce((str, x) => {
-      str += `- ${x}\n`;
+    new: scriptTypes.reduce((str, x) => {
+      str += `- ${x.name}\n`;
       return str;
     }, ''),
   },