From af5420b8a41936d3c08c0b5f8a4f413948c789a4 Mon Sep 17 00:00:00 2001 From: Shen Date: Tue, 26 Sep 2017 14:52:50 -0400 Subject: [PATCH] [Dashboard] bug fix- user has issue tracker permission,but can't find issue track in the task menu. (#3145) The dashboard doesn't display the issue trackers widget in the task menu if you only have issue_tracker_developer permission. This fixes the template to display it. --- .../dashboard/templates/form_dashboard.tpl | 2 +- modules/dashboard/test/TestPlan.md | 19 +++++++++++-------- 2 files changed, 12 insertions(+), 9 deletions(-) diff --git a/modules/dashboard/templates/form_dashboard.tpl b/modules/dashboard/templates/form_dashboard.tpl index 1eb27fd0d08..9ce5080ceae 100644 --- a/modules/dashboard/templates/form_dashboard.tpl +++ b/modules/dashboard/templates/form_dashboard.tpl @@ -120,7 +120,7 @@
- {if $new_scans neq "" or $conflicts neq "" or $incomplete_forms neq "" or $radiology_review neq "" or $violated_scans neq "" or $pending_users neq ""} + {if $new_scans neq "" or $conflicts neq "" or $incomplete_forms neq "" or $radiology_review neq "" or $violated_scans neq "" or $pending_users neq "" or $issues_assigned neq ""}
diff --git a/modules/dashboard/test/TestPlan.md b/modules/dashboard/test/TestPlan.md index 5b150812deb..488ebe70dc1 100644 --- a/modules/dashboard/test/TestPlan.md +++ b/modules/dashboard/test/TestPlan.md @@ -48,32 +48,35 @@ 14. Verify that if a user has 'Across all sites access candidate profiles' permission, the reports works and even more important to check without this permission. [Automate Test] -15. Verify that if a user has 'User Management / Survey Participant Management' permission, the number of pending +15. Verify that if a user has 'issue_tracker_reporter / issue_tracker_developer' permission, + the issue tracker panel should not be found without this permission. + [Automate Test on Travis_CI] +16. Verify that if a user has 'User Management / Survey Participant Management' permission, the number of pending account approvals is displayed in the My Task panel. This should be the number of entries in the User Account page with the following Selection Filter: Site set to the user's site and Pending Approval set to 'Yes'. The Site displayed will be the user's site. Check that you are taken to that page (with the Selection Filter correctly set) when you click on the task. [Automate Test on Travis_CI] -16. Verify that a user with 'Violated Scans: View all-sites Violated Scans' permission has a task with the number +17. Verify that a user with 'Violated Scans: View all-sites Violated Scans' permission has a task with the number of violated scans displayed. This is the number of entries on the MRI Violated Scans page. The Site displayed will always be 'All'. Check that clicking on the task takes you to the Violated Scans page. [Automate Test on Travis_CI] -17. Verify that if a user has the 'View and upload files in Document Repository' or 'Delete files in Document Repository' +18. Verify that if a user has the 'View and upload files in Document Repository' or 'Delete files in Document Repository' permission, the latest documents to have been edited or uploaded in the document repository are displayed (4 at most) in the Document Repository panel. Clicking on a document will display it in the browser. Clicking on the Document Repository button takes you to the Document Repository page. [Automate Test] -18. Check that if a document notification occurred since the last login, it is labeled as 'New' in the Document +19. Check that if a document notification occurred since the last login, it is labeled as 'New' in the Document Repository panel. [Automate Test] -19. Check that a 'New' notification is not labeled 'New' anymore after login in again. +20. Check that a 'New' notification is not labeled 'New' anymore after login in again. [Manual Test] -20. Check performance on a large dataset (like IBIS) to make sure the dashboard page displays within a reasonable +21. Check performance on a large dataset (like IBIS) to make sure the dashboard page displays within a reasonable amount of time. [Manual Test] -21. When there are no candidates registered (i.e. first time install), the system should display a message indicating +22. When there are no candidates registered (i.e. first time install), the system should display a message indicating that there are no candidates in the DB yet instead of showing the candidates chart. [Manual Test] -22. When there are no scans done, the system should display a message indicating that no scans were made instead of +23. When there are no scans done, the system should display a message indicating that no scans were made instead of showing the scans chart. [Manual Test]