Telegram notification with VER=3.1.2

[stanthewizzard]

Hello There is an error

[mar. 09 sept. 2025 13:22:50 CEST] Skipped xxxxxx.com
[mar. 09 sept. 2025 13:22:50 CEST] _error_level='3'
[mar. 09 sept. 2025 13:22:50 CEST] _set_level='3'
[mar. 09 sept. 2025 13:22:50 CEST] Sending via: telegram
[mar. 09 sept. 2025 13:22:50 CEST] Found /root/.acme.sh/notify/telegram.sh for telegram
[mar. 09 sept. 2025 13:22:50 CEST] _statusCode='2'
[mar. 09 sept. 2025 13:22:50 CEST] _URGLY_PRINTF
[mar. 09 sept. 2025 13:22:50 CEST] xargs
[mar. 09 sept. 2025 13:22:50 CEST] {"text": "**\n", "chat_id": "443015641", "parse_mode": "MarkdownV2", "disable_web_page_preview": "1"}
[mar. 09 sept. 2025 13:22:50 CEST] POST
[mar. 09 sept. 2025 13:22:50 CEST] _post_url='https://api.telegram.org/botREDACTED/sendMessage'
[mar. 09 sept. 2025 13:22:50 CEST] body='{"text": "**\n", "chat_id": "REDACTED", "parse_mode": "MarkdownV2", "disable_web_page_preview": "1"}'
[mar. 09 sept. 2025 13:22:50 CEST] _postContentType
[mar. 09 sept. 2025 13:22:50 CEST] _CURL='curl --silent --dump-header /root/.acme.sh/http.header  -L  -g '
[mar. 09 sept. 2025 13:22:50 CEST] _ret='0'
[mar. 09 sept. 2025 13:22:50 CEST] telegram send error.
[mar. 09 sept. 2025 13:22:50 CEST] {"ok":false,"error_code":400,"description":"Bad Request: text must be non-empty"}
[mar. 09 sept. 2025 13:22:50 CEST] Error sending message using telegram_send
[mar. 09 sept. 2025 13:22:50 CEST] Error setting /root/.acme.sh/notify/telegram.sh.
[mar. 09 sept. 2025 13:22:50 CEST] �[1;32m===End cron===�[0m

Using previous telegram .sh is ok

Thansk for help

[github-actions]

Please upgrade to the latest code and try again first. Maybe it's already fixed. acme.sh --upgrade If it's still not working, please provide the log with --debug 2, otherwise, nobody can help you.

[stanthewizzard]

Same after update

[mar. 09 sept. 2025 13:41:32 CEST] Sending via: telegram
[mar. 09 sept. 2025 13:41:32 CEST] Found /root/.acme.sh/notify/telegram.sh for telegram
[mar. 09 sept. 2025 13:41:32 CEST] _statusCode='2'
sed: -e expression n°1, caractère 35: Fin d'intervalle invalide
sed: -e expression n°1, caractère 35: Fin d'intervalle invalide
[mar. 09 sept. 2025 13:41:32 CEST] _URGLY_PRINTF
[mar. 09 sept. 2025 13:41:32 CEST] xargs
[mar. 09 sept. 2025 13:41:32 CEST] {"text": "\n", "chat_id": "443015641", "parse_mode": "MarkdownV2", "disable_web_page_preview": "1"}
[mar. 09 sept. 2025 13:41:32 CEST] POST
[mar. 09 sept. 2025 13:41:32 CEST] _post_url='https://api.telegram.org/bot5933875921:AAGZcDiJqDCyMPD5-tpNF8Nj3uUWnj2M8lg/sendMessage'
[mar. 09 sept. 2025 13:41:32 CEST] body='{"text": "\n", "chat_id": "443015641", "parse_mode": "MarkdownV2", "disable_web_page_preview": "1"}'
[mar. 09 sept. 2025 13:41:32 CEST] _postContentType
[mar. 09 sept. 2025 13:41:32 CEST] _CURL='curl --silent --dump-header /root/.acme.sh/http.header -L --trace-ascii /tmp/tmp.yAvGfTlAIe -g '
[mar. 09 sept. 2025 13:41:32 CEST] _ret='0'
[mar. 09 sept. 2025 13:41:32 CEST] telegram send error.
[mar. 09 sept. 2025 13:41:32 CEST] {"ok":false,"error_code":400,"description":"Bad Request: text must be non-empty"}
[mar. 09 sept. 2025 13:41:32 CEST] Error sending message using telegram_send
[mar. 09 sept. 2025 13:41:32 CEST] Error setting /root/.acme.sh/notify/telegram.sh.
[mar. 09 sept. 2025 13:41:32 CEST] ===End cron===

[stanthewizzard]

this code works

#!/usr/bin/env sh
# telegram.sh (hardened, no _json_encode)
# - Sends Telegram message using application/x-www-form-urlencoded.
# - Avoids acme.sh _json_encode which can hang in some environments.
# - POSIX-safe escaping for MarkdownV2 and URL form encoding.
# - Logs key steps to help diagnose.
# - Uses acme.sh helpers: _readaccountconf_mutable, _saveaccountconf_mutable,
#   _post, _info, _err (provided by acme.sh runtime).
# Code/comments: ASCII only.

telegram_send() {
  _subject="$1"
  _content="$2"
  _statusCode="$3" # 0=success, 1=error, 2=skipped

  _info "telegram: enter (status=$_statusCode)"

  TELEGRAM_BOT_APITOKEN="${TELEGRAM_BOT_APITOKEN:-$(_readaccountconf_mutable TELEGRAM_BOT_APITOKEN)}"
  if [ -z "$TELEGRAM_BOT_APITOKEN" ]; then
    TELEGRAM_BOT_APITOKEN=""
    _err "telegram: TELEGRAM_BOT_APITOKEN not set."
    return 1
  fi
  _saveaccountconf_mutable TELEGRAM_BOT_APITOKEN "$TELEGRAM_BOT_APITOKEN"

  TELEGRAM_BOT_CHATID="${TELEGRAM_BOT_CHATID:-$(_readaccountconf_mutable TELEGRAM_BOT_CHATID)}"
  if [ -z "$TELEGRAM_BOT_CHATID" ]; then
    TELEGRAM_BOT_CHATID=""
    _err "telegram: TELEGRAM_BOT_CHATID not set."
    return 1
  fi
  _saveaccountconf_mutable TELEGRAM_BOT_CHATID "$TELEGRAM_BOT_CHATID"

  TELEGRAM_BOT_URLBASE="${TELEGRAM_BOT_URLBASE:-$(_readaccountconf_mutable TELEGRAM_BOT_URLBASE)}"
  if [ -z "$TELEGRAM_BOT_URLBASE" ]; then
    TELEGRAM_BOT_URLBASE="https://api.telegram.org"
  fi
  _saveaccountconf_mutable TELEGRAM_BOT_URLBASE "$TELEGRAM_BOT_URLBASE"

  TELEGRAM_PARSE_MODE="${TELEGRAM_PARSE_MODE:-$(_readaccountconf_mutable TELEGRAM_PARSE_MODE)}"
  if [ -z "$TELEGRAM_PARSE_MODE" ]; then
    # Keep MarkdownV2 by default; set to empty to send plain text.
    TELEGRAM_PARSE_MODE="MarkdownV2"
  fi
  _saveaccountconf_mutable TELEGRAM_PARSE_MODE "$TELEGRAM_PARSE_MODE"

  # Defaults when both are empty (typical for "skipped")
  if [ -z "$_subject" ] && [ -z "$_content" ]; then
    case "$_statusCode" in
      0) _subject="acme.sh"; _content="Certificate renewed successfully." ;;
      1) _subject="acme.sh"; _content="Error during certificate operation." ;;
      2) _subject="acme.sh"; _content="No renewal needed (skipped)." ;;
      *) _subject="acme.sh"; _content="Notification." ;;
    esac
  fi

  # MarkdownV2 escaping (per-char, no sed char-classes)
  _escape_mdv2() {
    # $1: text
    # Escape backslash first, then special chars: _ * [ ] ( ) ~ ` > # + - = | { } . !
    _t=$(printf "%s" "$1" | sed 's/\\/\\\\/g')
    _t=$(printf "%s" "$_t" | sed 's/_/\\_/g')
    _t=$(printf "%s" "$_t" | sed 's/\*/\\*/g')
    _t=$(printf "%s" "$_t" | sed 's/\[/\\[/g')
    _t=$(printf "%s" "$_t" | sed 's/\]/\\]/g')
    _t=$(printf "%s" "$_t" | sed 's/(/\\(/g')
    _t=$(printf "%s" "$_t" | sed 's/)/\\)/g')
    _t=$(printf "%s" "$_t" | sed 's/~/\\~/g')
    _t=$(printf "%s" "$_t" | sed 's/`/\\`/g')
    _t=$(printf "%s" "$_t" | sed 's/>/\\>/g')
    _t=$(printf "%s" "$_t" | sed 's/#/\\#/g')
    _t=$(printf "%s" "$_t" | sed 's/+/\\+/g')
    _t=$(printf "%s" "$_t" | sed 's/-/\\-/g')
    _t=$(printf "%s" "$_t" | sed 's/=/\\=/g')
    _t=$(printf "%s" "$_t" | sed 's/|/\\|/g')
    _t=$(printf "%s" "$_t" | sed 's/{/\\{/g')
    _t=$(printf "%s" "$_t" | sed 's/}/\\}/g')
    _t=$(printf "%s" "$_t" | sed 's/\./\\./g')
    _t=$(printf "%s" "$_t" | sed 's/!/\\!/g')
    printf "%s" "$_t"
  }

  if [ "$TELEGRAM_PARSE_MODE" = "MarkdownV2" ]; then
    _subject="$(_escape_mdv2 "$_subject")"
    _content="$(_escape_mdv2 "$_content")"
    _formatted=$(printf "*%s*\n%s" "$_subject" "$_content")
  else
    _formatted=$(printf "%s\n%s" "$_subject" "$_content")
  fi

  # Ensure non-empty after formatting
  _trimmed=$(printf "%s" "$_formatted" | tr -d ' \t\r\n')
  if [ -z "$_trimmed" ] || [ "$_formatted" = "**\n" ] || [ "$_formatted" = "*\n" ]; then
    _formatted="acme.sh notification"
  fi

  _len=$(printf "%s" "$_formatted" | wc -c | awk '{print $1}')
  _info "telegram: built message (${_len} bytes)"

  # URL-encode for x-www-form-urlencoded
  _urlencode() {
    # POSIX-safe URL encoder
    # shellcheck disable=SC2039
    _in="$1"
    _out=""
    # Treat LF as %0A; keep space as %20
    i=1
    # Use awk substr to stay POSIX
    while [ $i -le $(printf "%s" "$_in" | wc -c | awk '{print $1}') ]; do
      ch=$(printf "%s" "$_in" | awk -v n=$i 'BEGIN{RS="";} {printf "%s", substr($0,n,1)}')
      case "$ch" in
        [a-zA-Z0-9.~_-]) _out="${_out}${ch}" ;;
        ' ')              _out="${_out}%20" ;;
        *)                hex=$(printf "%02X" "'$ch"); _out="${_out}%${hex}" ;;
      esac
      i=$((i+1))
    done
    printf "%s" "$_out"
  }

  enc_text="$(_urlencode "$_formatted")"
  enc_chat="$(_urlencode "$TELEGRAM_BOT_CHATID")"

  # Build form body
  form="chat_id=${enc_chat}&text=${enc_text}&disable_web_page_preview=1"
  if [ -n "$TELEGRAM_PARSE_MODE" ]; then
    enc_mode="$(_urlencode "$TELEGRAM_PARSE_MODE")"
    form="${form}&parse_mode=${enc_mode}"
  fi

  _url="$TELEGRAM_BOT_URLBASE/bot$TELEGRAM_BOT_APITOKEN/sendMessage"
  _info "POST (form): $_url"

  # Use acme.sh _post with form content-type
  response="$(_post "$form" "$_url" "" "POST" "application/x-www-form-urlencoded")"

  if printf "%s" "$response" | grep -q '"ok":[[:space:]]*true'; then
    _info "telegram: send success"
    return 0
  fi

  _err "telegram: send error"
  _err "$response"
  return 1
}