Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #73 : Event cards height and adds responsiveness to event carousel #90

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fixes #73 : Event cards height and adds responsiveness to event carousel #90

wants to merge 3 commits into from

Conversation

shreyaskaundinya
Copy link

Title

Fixes

  • Event card height and alignment
  • Event card carousel responsiveness in tablet and mobile views
  • Event Carousel arrow onClick

Description

Alignment :
image

Responsiveness :

Desktop
Same as above

Tablet
image
image

Mobile
image
image
image

Issue Closed

Closes #73

Notes [DELETE BEFORE SUBMITTING PR]

  • Only submit 1 PR per issue and make only 1 Issue is solved per PR
  • Make sure you've gone through the contributing guidelines.
  • All your commits will be squashed into 1 commit during the merge
  • The review process may take a while, be patient
  • This section must be deleted before submitting the PR

@arnxv0
Copy link
Collaborator

arnxv0 commented Oct 15, 2021

image

The logos on these cards are still not aligned.

@shreyaskaundinya
Copy link
Author

image

The logos on these cards are still not aligned.

Will fix!

@shreyaskaundinya
Copy link
Author

Could i also fix the lazy loading? it doesn't seem to be working...

@arnxv0
Copy link
Collaborator

arnxv0 commented Oct 15, 2021

Could i also fix the lazy loading? it doesn't seem to be working...

Sure, you might get some additional points for it too :)

@shreyaskaundinya
Fixes lazy loading of images
1ca83e2
@shreyaskaundinya
Fixes :
0af5c30 
- Member cards responsiveness
- Member cards github and email icon alignment
- Removal of  duplicate imports of bootstrap and font awesome
@shreyaskaundinya
Copy link
Author

Member cards

Desktop
image

Tablet
image

Mobile
image

@techverve
Copy link
Member

issue1
the 5th core member picture is not inline

@shreyaskaundinya
Copy link
Author

That is because of overflow... The content wouldn't fit if I made it 5 in a row...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Standardize the events card size and align the read more button
3 participants
@shreyaskaundinya @arnxv0 @techverve