Feature/statistics#9
Merged
alexzhang1618 merged 8 commits intomainfrom Dec 10, 2024
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
angela139
requested changes
Nov 22, 2024
Collaborator
angela139
left a comment
angela139
left a comment
There was a problem hiding this comment.
Overall, it looks really good to me! I left some comments and nits
Contributor
|
Cleaned up the code and updated the mobile layout + the hanging guy Screen.Recording.2024-12-09.at.8.13.34.PM.mov |
SheepTester
approved these changes
Dec 10, 2024
Member
There was a problem hiding this comment.
looks good! the image looks a bit low quality on my screen, maybe export a higher quality version from Figma? (with 2x resolution; or use SVG)
animating the guy sliding down could potentially be done by exporting the diamond guy as a separate image, then using position: sticky; top: 0;. the heister will be constrained to the bounds of its parent element, so that can be used to prevent it from sliding off the rope. but this can/should be done in a separate PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Info
Closes [#2 ].
Implements the statistics section.
Changes
Type of Change
expected)
linting/formatting)
workflows)
Testing
I have tested that my changes fully resolve the linked issue ...
Checklist
/src/lib/*and commented hard to understand areasanywhere else.
Screenshots