Event feedback

[SheepTester]

Info

Closes #121

Please note: Currently, the admin test account cannot submit feedback because someone requested a password reset.

Currently waiting on acmucsd/membership-portal#412, which links feedback to events

I added separate event pages and made event cards link to them. Clicking on an event card still opens the modal, but now you can ctrl + click on event cards to quickly open them in new tabs. Also, since the modal is already a form, and HTML doesn't allow forms within forms, I can't put the feedback form in a modal. So the event page is where you give feedback for events

To access the feedback form on the event page:

• Click on an event > Click on "Give feedback" (currently a barely styled link)
• Ctrl + click (or right click/long press > open in a new tab) on an event card to open the page in a new tab

To access the feedback page:

• Admin settings > Events > View Feedback
• Go directly to /feedback in the address bar. The API supports getting feedback for normal users, but it just lists the users' submitted feedback. This is supported by the feedback page, but I don't think it's as important to link it anywhere

I'm thinking of adding multiple-choice options to the feedback form (e.g. How did you hear about this event? What made you spend time at this event? [and if the user didn't attend the event] Why didn't you attend the event?). Since the API just stores feedback as one string, this could just be concatenated together into a both human- and program-readable string

Changes

• [Fill in here]

Type of Change

• Bug Fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as
  expected)
• Logistics Change (A change to a README, description, or dev workflow setup like
  linting/formatting)
• Continuous Integration Change (Related to deployment steps or continuous integration
  workflows)
• Other: (Fill In)

Testing

I have tested that my changes fully resolve the linked issue ...

• locally on Desktop.
• on the live deployment preview on Desktop.
• on the live deployment preview on Mobile.
• I have added new Cypress tests that are passing.

Checklist

• I have performed a self-review of my own code.
• I have followed the style guidelines of this project.
• I have documented any new functions in /src/lib/* and commented hard to understand areas
  anywhere else.
• My changes produce no new warnings.

Screenshots

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
membership-portal-ui-v2	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 1, 2024 6:33pm

[alexzhang1618]

Functionality works great!

Some comments:

• Thoughts on adding labels for the form items? It might just be me but I started typing and didn't realize the first item was how did you hear about this event

[alexzhang1618]

code lgtm, just some styling comments:

Can we make the background elevated for feedback here