Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile backgrounds #204

Merged
merged 10 commits into from
Mar 31, 2024
Merged

Profile backgrounds #204

merged 10 commits into from
Mar 31, 2024

Conversation

SheepTester
Copy link
Member

Info

Closes #120

generates a pie chart based on the communities of "recently attended" on the profile, then blurs the shapes individually

Changes

  • increased banner size

Type of Change

  • Bug Fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)
  • Logistics Change (A change to a README, description, or dev workflow setup like
    linting/formatting)
  • Continuous Integration Change (Related to deployment steps or continuous integration
    workflows)
  • Other: (Fill In)

Testing

I have tested that my changes fully resolve the linked issue ...

  • locally on Desktop.
  • on the live deployment preview on Desktop.
  • on the live deployment preview on Mobile.
  • I have added new Cypress tests that are passing.

Checklist

  • I have performed a self-review of my own code.
  • I have followed the style guidelines of this project.
  • I have documented any new functions in /src/lib/* and commented hard to understand areas
    anywhere else.
  • My changes produce no new warnings.

Screenshots

20240330-2307-10.9124990.1.mp4

For some reason the blur looks glitchy
don't shuffle the communities so banners dont change when we add more in the future
Copy link

vercel bot commented Mar 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
membership-portal-ui-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 31, 2024 1:32am

Adjust spacing for other profile things
Copy link
Member

@farisashai farisashai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to merge whenever you decide on missing backgrounds

@SheepTester
Copy link
Member Author

for now we'll just hide banners on profiles without any attendance history. we can decide on a better option in the future

@SheepTester SheepTester merged commit a97c090 into main Mar 31, 2024
5 checks passed
@SheepTester SheepTester deleted the sean/profile-bgs branch March 31, 2024 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generate Dynamic Profile Background Image per User
3 participants