Tab titles #205
Merged
Tab titles #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pages that did not change: - The home page - Login, because that's the website preview that'll show on Discord - The 404 and 500 pages
SheepTester
requested review from
farisashai,
raymosun,
trevorkw7 and
alexzhang1618
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
copied from d717bfa
Co-authored-by: Alex Zhang <[email protected]>
Co-authored-by: Alex Zhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Info
this doesnt fix an issue
it was a bit annoying trying to find a page in my browser history on the current membership portal. giving each page a title
Since we're using Next.JS and SSR, we benefit from being able to set the page title/description on the server side, so they can show up in the website previews on Discord. not that it really matters since pretty much every page
Changes
_appnow takes atitleanddescriptioncomponent, which will be passed toSEOto set the page title/description.| ACM UCSD Membership Portalgets appended to the end of these titles, if specified (but maybe we could shorten these to justPage Title | ACM?)Type of Change
expected)
linting/formatting)
workflows)
Testing
I have tested that my changes fully resolve the linked issue ...
Checklist
/src/lib/*and commented hard to understand areasanywhere else.
Screenshots