Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prettier pagination #213

Merged
merged 5 commits into from
Apr 13, 2024
Merged

Prettier pagination #213

merged 5 commits into from
Apr 13, 2024

Conversation

alexzhang1618
Copy link
Contributor

@alexzhang1618 alexzhang1618 commented Mar 31, 2024

Info

Closes #169

[description]

Changes

  • [Fill in here]

Type of Change

  • Bug Fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)
  • Logistics Change (A change to a README, description, or dev workflow setup like
    linting/formatting)
  • Continuous Integration Change (Related to deployment steps or continuous integration
    workflows)
  • Other: (Fill In)

Testing

I have tested that my changes fully resolve the linked issue ...

  • locally on Desktop.
  • on the live deployment preview on Desktop.
  • on the live deployment preview on Mobile.
  • I have added new Cypress tests that are passing.

Checklist

  • I have performed a self-review of my own code.
  • I have followed the style guidelines of this project.
  • I have documented any new functions in /src/lib/* and commented hard to understand areas
    anywhere else.
  • My changes produce no new warnings.

Screenshots

Copy link

vercel bot commented Mar 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
membership-portal-ui-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 13, 2024 8:33pm
testing-membership-portal-ui-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 13, 2024 8:33pm

Copy link
Member

@SheepTester SheepTester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

page numbers are broken on leaderboard:

image

image

Should we make the current number an input to still allow people to enter in a page number. like if they hover/focus on the blue number, the input reveals a border/background color

image

Maybe it could show nothing if there's only one page

@WishingWell13 WishingWell13 linked an issue Apr 3, 2024 that may be closed by this pull request
@alexzhang1618
Copy link
Contributor Author

Screenshot 2024-04-13 at 12 37 06 PM
Switching to a simpler, redesigned version of pagination

Copy link
Member

@SheepTester SheepTester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prettier Pagination
2 participants