Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added patching and deleting to events portal #258

Merged
merged 3 commits into from
May 22, 2024

Conversation

newracket
Copy link
Contributor

@newracket newracket commented May 15, 2024

Info

Closes #257

Adding patch/delete to admin portal.

Changes

  • Added klefki patch/delete
  • Added delete button to admin portal

Type of Change

  • Bug Fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)
  • Logistics Change (A change to a README, description, or dev workflow setup like
    linting/formatting)
  • Continuous Integration Change (Related to deployment steps or continuous integration
    workflows)
  • Other: (Fill In)

Testing

I have tested that my changes fully resolve the linked issue ...

  • locally on Desktop.
  • on the live deployment preview on Desktop.
  • on the live deployment preview on Mobile.
  • I have added new Cypress tests that are passing.

Checklist

  • I have performed a self-review of my own code.
  • I have followed the style guidelines of this project.
  • I have documented any new functions in /src/lib/* and commented hard to understand areas
    anywhere else.
  • My changes produce no new warnings.

Screenshots

image

Copy link

vercel bot commented May 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
membership-portal-ui-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 22, 2024 11:27pm
testing-membership-portal-ui-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 22, 2024 11:27pm

Copy link
Contributor

@alexzhang1618 alexzhang1618 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good just some code quality comments

src/components/admin/event/ManageEventCard/index.tsx Outdated Show resolved Hide resolved
src/components/admin/event/ManageEventCard/index.tsx Outdated Show resolved Hide resolved
src/lib/api/KlefkiAPI.ts Outdated Show resolved Hide resolved
src/lib/managers/AdminEventManager.ts Outdated Show resolved Hide resolved
src/lib/types/apiResponses.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@alexzhang1618 alexzhang1618 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just one thingy

src/lib/types/apiRequests.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Discord event patch/delete
2 participants