Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create EventCard Component #96

Merged
merged 13 commits into from
Dec 27, 2023
Merged

Create EventCard Component #96

merged 13 commits into from
Dec 27, 2023

Conversation

alexzhang1618
Copy link
Contributor

@alexzhang1618 alexzhang1618 commented Dec 20, 2023 •
edited
Loading

Changes

  • Fixed some sizing bugs in Typography (small was larger than large, ...)
  • Added CommunityLogo in components to render the logo for a community
  • Added an event display on the dashboard along with event cards that pop up modals when clicked
    • Components for this are under components/event
  • Added the ics package to support calendar exports for events
  • Add a new API call to get attendances for the current user

Type of Change

  • Bug Fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as
    expected)
  • Logistics Change (A change to a README, description, or dev workflow setup like
    linting/formatting)
  • Continuous Integration Change (Related to deployment steps or continuous integration
    workflows)
  • Other: (Fill In)

Testing

I have tested that my changes fully resolve the linked issue ...

  • locally on Desktop.
  • locally on mobile - use https://ngrok.io to get a copy on a mobile device
  • on the live deployment preview on Desktop.
  • on the live deployment preview on Mobile.
  • I have run and passed all new and existing Cypress tests. Add screenshots below.

Checklist

  • I have performed a self-review of my own code.
  • I have followed the style guidelines of this project.
  • I have documented my code's src/lib functions and commented hard to understand areas
    anywhere else.
  • My changes produce no new warnings.

Screenshots

Screenshot 2023-12-20 at 3 45 41 PM Screenshot 2023-12-20 at 3 46 00 PM Screenshot 2023-12-20 at 3 46 12 PM

@vercel Vercel
Copy link

vercel bot commented Dec 20, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
membership-portal-ui-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 27, 2023 4:57pm

SheepTester
SheepTester requested changes Dec 27, 2023
View reviewed changes
src/components/events/CalendarButtons/index.tsx Outdated Show resolved Hide resolved
src/components/events/CalendarButtons/style.module.scss Outdated Show resolved Hide resolved
src/components/events/EventCard/index.tsx Outdated Show resolved Hide resolved
src/components/events/EventCard/style.module.scss Outdated Show resolved Hide resolved
src/components/events/EventCard/style.module.scss Outdated Show resolved Hide resolved
src/components/events/EventModal/index.tsx Outdated Show resolved Hide resolved
src/components/events/EventModal/index.tsx Show resolved Hide resolved
src/components/events/EventModal/style.module.scss Show resolved Hide resolved
src/components/events/EventModal/style.module.scss Show resolved Hide resolved
src/components/events/PointsDisplay/index.tsx Outdated Show resolved Hide resolved
farisashai
farisashai requested changes Dec 27, 2023
View reviewed changes
Copy link
Member

@farisashai farisashai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sean covered everything visual mostly - biggest feedback is reuse his modal component or find a way to unify the two and resolve the scrolling underneath the modal bug

src/components/common/CommunityLogo/index.tsx Outdated Show resolved Hide resolved
src/components/events/EventModal/index.tsx Outdated Show resolved Hide resolved
src/components/events/EventModal/style.module.scss Outdated Show resolved Hide resolved
src/components/events/EventModal/style.module.scss Show resolved Hide resolved
src/components/events/PointsDisplay/style.module.scss Outdated Show resolved Hide resolved
src/components/events/EventModal/style.module.scss Show resolved Hide resolved
farisashai
farisashai approved these changes Dec 27, 2023
View reviewed changes
Copy link
Member

@farisashai farisashai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine at a quick glance, approving so it's not blocked - sean can do a sanity check if he wants

SheepTester
SheepTester approved these changes Dec 27, 2023
View reviewed changes
Copy link
Member

@SheepTester SheepTester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

src/components/events/CalendarButtons/index.tsx Show resolved Hide resolved
@alexzhang1618 alexzhang1618 merged commit c018d21 into main Dec 27, 2023
4 checks passed
@alexzhang1618 alexzhang1618 deleted the feature/event-card branch December 27, 2023 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@farisashai farisashai farisashai approved these changes

@SheepTester SheepTester SheepTester approved these changes

@raymosun raymosun Awaiting requested review from raymosun raymosun is a code owner

@trevorkw7 trevorkw7 Awaiting requested review from trevorkw7 trevorkw7 is a code owner

Assignees

@alexzhang1618 alexzhang1618

Labels
PR: Good to Merge PR: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexzhang1618 @SheepTester @farisashai