click-odoo-backupdb: subprocess DeprecationWarning

[psugne]

Used:
python3.10
Odoo 16.0

Tested and noticed only on Odoo version 16.0

Traceback:

py.warnings: /opt/odoo/venv/lib/python3.10/site-packages/click_odoo_contrib/backupdb.py:28: DeprecationWarning: Since 16.0, just use `subprocess`.
  File "/opt/odoo/venv/bin/click-odoo-backupdb", line 8, in <module>
    sys.exit(main())
  File "/opt/odoo/venv/lib/python3.10/site-packages/click/core.py", line 1130, in __call__
    return self.main(*args, **kwargs)
  File "/opt/odoo/venv/lib/python3.10/site-packages/click/core.py", line 1055, in main
    rv = self.invoke(ctx)
  File "/opt/odoo/venv/lib/python3.10/site-packages/click_odoo/env_options.py", line 199, in _invoke
    return self.org_invoke(ctx)
  File "/opt/odoo/venv/lib/python3.10/site-packages/click/core.py", line 1404, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/opt/odoo/venv/lib/python3.10/site-packages/click/core.py", line 760, in invoke
    return __callback(*args, **kwargs)
  File "/opt/odoo/venv/lib/python3.10/site-packages/click_odoo_contrib/backupdb.py", line 121, in main
    _dump_db(dbname, _backup)
  File "/opt/odoo/venv/lib/python3.10/site-packages/click_odoo_contrib/backupdb.py", line 28, in _dump_db
    _stdin, stdout = odoo.tools.exec_pg_command_pipe(*cmd)

A Warning comes on doing a backup from here where Odoo warns about deprecation here. Related with Odoo commit.

[JakubSs]

is there any update?

[psugne]

is there any update?

Still no feedback

[sbidoul]

This still works in 17. No time to handle this today. A PR is welcome.

[peterromao]

I am having this too on Odoo 16.0 20240216 build. Python 3.9.

Is this just a question of substituting
_stdin, stdout = odoo.tools.exec_pg_command_pipe(*cmd)
to
_stdin, stdout = subprocess.run(cmd, env=env, stdout=subprocess.DEVNULL, stderr=subprocess.STDOUT, check=True)

?

I don't even know where to change this to test.