Checkout does not work when the server is configured with a sub-path

[psa]

I have a Gitea server configured with sub-paths (e.g. htttp://example.com/path/to/git/owner/repository.git). Checkout attempts to checkout https://example.com/owner/repository.git and throws away the sub-path.

How to replicate:

• Setup a Gitea server (or any other supported git server) behind a reverse proxy with a sub-path
• Have an action which uses actions/checkout
• Watch the logs and see that the called URL is missing the sub-path.

My best guess is that it's lost in https://github.com/actions/checkout/blob/f095bcc56b7c2baf48f3ac70d6d6782f4f553222/src/url-helper.ts#LL19C1-L19C1 as, according to the comment, serviceUrl.origin is SCHEME://HOSTNAME[:PORT]

[RouxAntoine]

Hello i came to the same conclusion as you. and that pretty sad, do you have found a workaround ?

[RouxAntoine]

tag on a fork with a fix https://github.com/RouxAntoine/checkout/tree/v3.5.4

[kdumontnu]

Thanks for reporting & the proposed fix. I can confirm your patch fixed the bug for me. Looking forward to seeing it get merged 🤞

[RouxAntoine]

Your welcome, I hope too, however I am afraid of the number of issues and pull request on a so used and so small action.

[frankli0324]

I believe this issue is a dulplicate #1242
also the PR is also dulplicated: #1305 @RouxAntoine

[RouxAntoine]

indeed it seems, I close mine 🙂, moreover I am not totaly sure that the regex parsing is necessary

export function getBaseUrl(url: string): string {
  const matcher = url.match(/^[^?]+/)
  return (matcher && matcher[0].replace(/\/+$/g, '')) || ''
}

[frankli0324]

https://instance.com/test/?region=asdf, I think removing the trailing / is generally a good practice, especially for this kind of url that often comes with concatenation?

[RouxAntoine]

not totally sure, but if yes, so :

export function trimEndingSlash(input: string): string {
  return input.replace(/\/$/, "");
}

My point is here is no reason to parse serverUrl.href this should be kept simple and use attribute pathname of Object URL https://developer.mozilla.org/en-US/docs/Web/API/URL/pathname

[OdinVex]

This repository is a clone of Gitea's Action Checkout with the sub-path fix: https://gitea.com/ScMi1/checkout

[joshmgross]

Closing as duplicate of #1242, which we're not planning to support at this time.