Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v4's show-progress flag should suppress "git checkout" as well #1455

Open
ychin opened this issue Sep 5, 2023 · 0 comments
Open

v4's show-progress flag should suppress "git checkout" as well #1455

ychin opened this issue Sep 5, 2023 · 0 comments

Comments

@ychin
Copy link

ychin commented Sep 5, 2023

v4 recently introduced a "show-progress" flag that will suppress the "--progress" flag from Git fetch. However, this action will then perform a "git checkout" later with a hard-coded --progress flag. I think it makes sense to also remove it if show-progress: false is specified. I think it would be rare for someone to care about the progress in checkout but not fetch to begin with, so keeping this the same for both Git fetch and checkout will keep it simple.

Note: There's an existing bug where this flag currently doesn't do anything and always defaults to false (it should default to true) (#1453). This suggestion is assuming the bug got fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant