-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
post-action warning on revoke failure in case token already expired #140
Comments
We do already check for expiration time, maybe we got it implemented wrong though? create-github-app-token/lib/post.js Lines 24 to 28 in c8f55ef
|
I just want to +1 to this issue. |
thanks for letting us know @dboriichuk. That suggests that our expiration check is not working. I'll add more logs to get to the bottom of it |
🎉 This issue has been resolved in version 1.10.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
I'm seeing the following warning in the post job cleanup step:
Probably because the token was already invalidated, because the job took more than 1h to run (see #121).
No issue here other than there shouldn't be any warning in this case.
The text was updated successfully, but these errors were encountered: