-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Research learnings and ideas from similar GitHub Actions #42
Comments
I looked through them again and two things that stood out for me
There is also a lot to learn in terms of documentation, in particular how to register a GitHub App. |
I was trying to migrate from the action peter-murray/workflow-application-token-action to this one, and I noticed this action does not support the private-key input as a Base64 encoded string. Does it make sense to create an issue for that? I don't have any problem opening a PR to support that use case. Also, an issue we have with the action peter-murray/workflow-application-token-action that didn't have any internal retry mechanism; maybe we can improve that in this action. I will be happy to start working in some PRs to improve this action |
what is the use case? Maybe the decoding a base64 string could be done in a separate step before using this action?
For retries, @octokit has the retry plugin, it's rather heavy though, due to its dependency on |
So joining these two use cases, I have experienced failures getting the token from a GitHub app, so we start to use an extra action to retry Wandalen/wretry.action, then we have the issue with the input that is broken with multiline strings like the format of the PEM files, so we had to do encode the private key with base64. Also, it is annoying to keep copying and pasting the ugly syntax of an action that retries another action. So, does it make sense to implement a retry logic inside the action? |
would replacing line breaks with "\n" work? That's what we do in environments where multi-line environment variables are not supported
Perfect 👍🏼 I agree we should implement a retry, could you please file a separate issue for it? |
I would like to try and help implement the proxy support. Getting this working from self-hosted runners behind a corporate proxy is important for my project. |
@newbloke82 makes sense, thank you for laying it out! Can you please first file an issue? I think |
Follow up to #39 (comment).
In preparation for #3 and #4 it might make sense to learn from similar actions.
The text was updated successfully, but these errors were encountered: